paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Simplify settings_list_widget interface.

Browse Source 
We move more common code into settings_lsit_widget for cleaner code
in settings_org.js.
This commit is contained in:
Rohitt Vashishtha
2020-04-15 02:29:15 +00:00
committed by Tim Abbott
parent e79935dbf7
commit 41481a906c
4 changed files with 67 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
static/js/settings_list_widget.js
View File

@@ -8,31 +8,6 @@ const DropdownListWidget = function (opts) {
const render_dropdown_list = require("../templates/settings/dropdown_list.hbs");
const setup = () => {
// populate the dropdown
const dropdown_list_body = $(`#${opts.container_id} .dropdown-list-body`).expectOne();
const search_input = $(`#${opts.container_id} .dropdown-search > input[type=text]`);
list_render.create(dropdown_list_body, opts.data, {
name: `${opts.setting_name}_list`,
modifier: function (item) {
return render_dropdown_list({ item: item });
},
filter: {
element: search_input,
predicate: function (item, value) {
return item.name.toLowerCase().includes(value);
},
},
});
$(`#${opts.container_id} .dropdown-search`).click(function (e) {
e.stopPropagation();
});
$(`#${opts.container_id} .dropdown-toggle`).click(function () {
search_input.val("").trigger("input");
});
};
const render = (value) => {
$(`#${opts.container_id} #${opts.value_id}`).data("value", value);
@@ -76,6 +51,35 @@ const DropdownListWidget = function (opts) {
});
};
const setup = () => {
// populate the dropdown
const dropdown_list_body = $(`#${opts.container_id} .dropdown-list-body`).expectOne();
const search_input = $(`#${opts.container_id} .dropdown-search > input[type=text]`);
list_render.create(dropdown_list_body, opts.data, {
name: `${opts.setting_name}_list`,
modifier: function (item) {
return render_dropdown_list({ item: item });
},
filter: {
element: search_input,
predicate: function (item, value) {
return item.name.toLowerCase().includes(value);
},
},
});
$(`#${opts.container_id} .dropdown-search`).click(function (e) {
e.stopPropagation();
});
$(`#${opts.container_id} .dropdown-toggle`).click(function () {
search_input.val("").trigger("input");
});
render(page_params[opts.setting_name]);
register_event_handlers();
};
const value = () => {
let val = $(`#${opts.container_id} #${opts.value_id}`).data('value');
if (val === null) {
@@ -84,10 +88,11 @@ const DropdownListWidget = function (opts) {
return val;
};
// Run setup() automatically on initialization.
setup();
return {
setup,
render,
register_event_handlers,
value,
};
};