From 4256567b4a804b0ed00956c284c39f1544c7d496 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Thu, 11 Mar 2021 13:48:43 -0800 Subject: [PATCH] puppeteer_tests: Correct {visible: false} to {hidden: true}. {visible: false} just redundantly specifies the default behavior, which is to wait for the selector to be present regardless of visibility. We want to wait for these selectors to be hidden. Signed-off-by: Anders Kaseorg --- frontend_tests/puppeteer_tests/08-admin.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend_tests/puppeteer_tests/08-admin.ts b/frontend_tests/puppeteer_tests/08-admin.ts index b2cfeece22..811a2d7cea 100644 --- a/frontend_tests/puppeteer_tests/08-admin.ts +++ b/frontend_tests/puppeteer_tests/08-admin.ts @@ -300,7 +300,7 @@ async function test_upload_realm_icon_image(page: Page): Promise { visible: true, }); await page.waitForSelector("#realm-icon-upload-widget .upload-spinner-background", { - visible: false, + hidden: true, }); await page.waitForSelector( '#realm-icon-upload-widget .image-block[src^="/user_avatars/2/realm/icon.png?version=2"]', @@ -312,7 +312,7 @@ async function delete_realm_icon(page: Page): Promise { await page.click("li[data-section='organization-profile']"); await page.click("#realm-icon-upload-widget .image-delete-button"); - await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false}); + await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true}); } async function test_organization_profile(page: Page): Promise { @@ -320,13 +320,13 @@ async function test_organization_profile(page: Page): Promise { const gravatar_selctor = '#realm-icon-upload-widget .image-block[src^="https://secure.gravatar.com/avatar/"]'; await page.waitForSelector(gravatar_selctor, {visible: true}); - await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false}); + await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true}); await test_upload_realm_icon_image(page); await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: true}); await delete_realm_icon(page); - await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {visible: false}); + await page.waitForSelector("#realm-icon-upload-widget .image-delete-button", {hidden: true}); await page.waitForSelector(gravatar_selctor, {visible: true}); } @@ -337,7 +337,7 @@ async function submit_default_user_settings(page: Page): Promise { ); await page.click("#org-submit-user-defaults"); const saved_status = '#org-submit-user-defaults[data-status="saved"]'; - await page.waitForSelector(saved_status, {visible: false}); + await page.waitForSelector(saved_status, {hidden: true}); } async function test_change_organization_default_language(page: Page): Promise {