paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

zjsunit: Remove set_global side effect from zrequire.

Browse Source 
ES6 and TS modules don’t insert themselves into `window`, so our tests
shouldn’t insert them either.  Since the test `window` behaves like
`global` now, we can rely on legacy modules that do insert themselves
to do it themselves.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-07-25 18:47:36 -07:00
parent 99563eb150
commit 428956c086
13 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/markdown.js
View File

@@ -1,12 +1,12 @@
zrequire('hash_util');
zrequire('katex', 'katex/dist/katex.min.js');
zrequire('marked', 'third/marked/lib/marked');
set_global('katex', zrequire('katex', 'katex/dist/katex.min.js'));
set_global('marked', zrequire('marked', 'third/marked/lib/marked'));
zrequire('util');
zrequire('fenced_code');
zrequire('stream_data');
zrequire('people');
zrequire('user_groups');
zrequire('emoji_codes', 'generated/emoji/emoji_codes');
set_global('emoji_codes', zrequire('emoji_codes', 'generated/emoji/emoji_codes'));
zrequire('emoji');
zrequire('message_store');
zrequire('markdown');