paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set initial user presences in O(n), not O(n²) time

Browse Source 
Previous code iteratively called set_user_status() once for each user;
which in turn was rerendering the user sidebar, also once for each user.

I changed the API a bit by replacing activity.set_user_status() with
activity.set_user_statuses(), plural, that takes an object and updates
all the user statuses in one go before rendering.

(imported from commit 1111c9029264f892f25e76d2e5e5ff996dcbc7ca)
This commit is contained in:
Scott Feeney
2013-07-11 15:51:26 -04:00
parent 8fcf208815
commit 4313f2ff1e
2 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
zephyr/static/js/activity.js
View File

@@ -143,11 +143,21 @@ exports.initialize = function () {
focus_ping();
};
exports.set_user_status = function (user_email, presence, server_time) {
if (user_email === page_params.email) {
// Set user statuses. `users` should be an object with user emails as keys
// and presence information (see `status_from_timestamp`) as values.
//
// The object does not need to include every user, only the ones
// whose presence you wish to update.
//
// This rerenders the user sidebar at the end, which can be slow if done too
// often, so try to avoid calling this repeatedly.
exports.set_user_statuses = function (users, server_time) {
$.each(users, function (email, presence) {
if (email === page_params.email) {
return;
}
user_info[user_email] = status_from_timestamp(server_time, presence);
user_info[email] = status_from_timestamp(server_time, presence);
});
update_users();
};

10
zephyr/static/js/zephyr.js
View File

@@ -72,10 +72,8 @@ $(function () {
"full_name": "Humbug Feedback Bot"});
}
$.each(page_params.initial_presences, function (email, presence) {
activity.set_user_status(email, presence, page_params.initial_servertime);
});
activity.set_user_statuses(page_params.initial_presences,
page_params.initial_servertime);
});
function within_viewport(row_offset, row_height) {
@@ -823,7 +821,9 @@ function get_updates_success(data) {
}
break;
case 'presence':
activity.set_user_status(event.email, event.presence, event.server_timestamp);
var users = {};
users[event.email] = event.presence;
activity.set_user_statuses(users, event.server_timestamp);
break;
}
});