paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_topic_history_util: Add retry mechanism to get_server_history.

Browse Source 
Earlier, in `get_server_history` the API call to fetch stream-topic
history didn't have a retry logic.

This commit adds a retry mechanism.

If the request to fetch stream topic history fails, we now retry
the request up to a fixed number of times before giving up.
This improves UX in case of temporary network issues.
This commit is contained in:
Prakhar Pratyush
2025-06-26 19:06:01 +05:30
committed by Tim Abbott
parent 2bf13c36be
commit 43249cb431
2 changed files with 58 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
web/tests/stream_topic_history.test.cjs
View File

@@ -2,7 +2,7 @@
const assert = require("node:assert/strict");
const {mock_esm, zrequire} = require("./lib/namespace.cjs");
const {mock_esm, set_global, zrequire} = require("./lib/namespace.cjs");
const {run_test, noop} = require("./lib/test.cjs");
const channel = mock_esm("../src/channel");
@@ -291,7 +291,6 @@ test("server_history_end_to_end", () => {
];
let get_success_callback;
let get_error_callback;
let on_success_called;
channel.get = (opts) => {
@@ -299,7 +298,6 @@ test("server_history_end_to_end", () => {
assert.deepEqual(opts.data, {allow_empty_topic_name: true});
assert.ok(stream_topic_history.is_request_pending_for(stream_id));
get_success_callback = opts.success;
get_error_callback = opts.error;
};
stream_topic_history_util.get_server_history(stream_id, noop);
@@ -309,9 +307,6 @@ test("server_history_end_to_end", () => {
stream_topic_history_util.get_server_history(stream_id, noop);
assert.ok(stream_topic_history.is_request_pending_for(stream_id));
get_error_callback();
assert.ok(!stream_topic_history.is_request_pending_for(stream_id));
stream_topic_history_util.get_server_history(stream_id, () => {
on_success_called = true;
});
@@ -345,6 +340,29 @@ test("server_history_end_to_end", () => {
assert.ok(on_success_called);
});
test("server_history_error", () => {
set_global("setTimeout", (f) => {
f();
});
stream_topic_history.reset();
const channel_id = 99;
let total_attempts = 0;
channel.get = (opts) => {
assert.equal(opts.url, "/json/users/me/99/topics");
assert.ok(stream_topic_history.is_request_pending_for(channel_id));
// This mocks error on each GET request.
opts.error();
total_attempts += 1;
};
stream_topic_history_util.get_server_history(channel_id, noop);
// Verify that we stop after MAX_RETRIES attempt.
assert.deepEqual(total_attempts, stream_topic_history_util.MAX_RETRIES);
assert.ok(!stream_topic_history.is_request_pending_for(channel_id));
});
test("ask_server_for_latest_topic_data", () => {
stream_topic_history.set_update_topic_last_message_id((stream_id, topic_name) => {
stream_topic_history_util.update_topic_last_message_id(stream_id, topic_name, noop);