paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

click_handlers: Remove click handler for closing stream settings.

Browse Source 
The click handler for closing stream settings in click_handlers.js
is removed as overlays.js contains common logic for closing all
overlays.

'exports.close' in subs.js is removed and 'hashchange.exit_overlay'
is used in 'overlays.open_overlay' call.
This commit is contained in:
sahil839
2020-05-06 03:56:35 +05:30
committed by Tim Abbott
parent 3ffc9466c9
commit 435e231567
2 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/click_handlers.js
View File

@@ -423,12 +423,6 @@ exports.initialize = function () {
$(".tooltip").remove(); $(".tooltip").remove();
}); });
$("#subscriptions_table").on("click", ".exit, #subscription_overlay", function (e) {
if ($(e.target).is(".exit, .exit-sign, #subscription_overlay, #subscription_overlay > .flex")) {
subs.close();
}
});
function do_render_buddy_list_tooltip(elem, title_data) { function do_render_buddy_list_tooltip(elem, title_data) {
elem.tooltip({ elem.tooltip({
template: render_buddy_list_tooltip(), template: render_buddy_list_tooltip(),

8
static/js/subs.js
View File

@@ -674,7 +674,9 @@ exports.launch = function (section) {
overlays.open_overlay({ overlays.open_overlay({
name: 'subscriptions', name: 'subscriptions',
overlay: $("#subscription_overlay"), overlay: $("#subscription_overlay"),
on_close: exports.close, on_close: function () {
hashchange.exit_overlay();
},
}); });
exports.change_state(section); exports.change_state(section);
}); });
@@ -683,10 +685,6 @@ exports.launch = function (section) {
} }
}; };
exports.close = function () {
hashchange.exit_overlay();
};
exports.switch_rows = function (event) { exports.switch_rows = function (event) {
const active_data = exports.get_active_data(); const active_data = exports.get_active_data();
let switch_row; let switch_row;