From 441f9f43e70b5eba9558ce4d04bf5d03640e3522 Mon Sep 17 00:00:00 2001
From: Pragati Agrawal <pragati22066@gmail.com>
Date: Sat, 16 May 2020 00:13:31 +0530
Subject: [PATCH] templates: Extract help link widget.

This block of html is used at many places so it's a good idea to create a
template for it.
---
 static/templates/help_link_widget.hbs                |  3 +++
 static/templates/settings/data_exports_admin.hbs     |  4 +---
 .../templates/settings/deactivated_users_admin.hbs   |  4 +---
 static/templates/settings/display_settings.hbs       |  4 +---
 .../settings/organization_permissions_admin.hbs      | 12 +++---------
 .../settings/organization_profile_admin.hbs          |  8 ++------
 .../settings/organization_settings_admin.hbs         |  4 +---
 static/templates/settings/settings_checkbox.hbs      |  4 +---
 static/templates/stream_types.hbs                    |  8 ++------
 static/templates/subscription_settings.hbs           |  4 +---
 10 files changed, 16 insertions(+), 39 deletions(-)
 create mode 100644 static/templates/help_link_widget.hbs

diff --git a/static/templates/help_link_widget.hbs b/static/templates/help_link_widget.hbs
new file mode 100644
index 0000000000..cb546f9514
--- /dev/null
+++ b/static/templates/help_link_widget.hbs
@@ -0,0 +1,3 @@
+<a href="{{ link }}" target="_blank">
+    <i class="fa fa-question-circle-o" aria-hidden="true"></i>
+</a>
diff --git a/static/templates/settings/data_exports_admin.hbs b/static/templates/settings/data_exports_admin.hbs
index 55ec41f608..8cf740f4f7 100644
--- a/static/templates/settings/data_exports_admin.hbs
+++ b/static/templates/settings/data_exports_admin.hbs
@@ -1,8 +1,6 @@
 <div id="data-exports" class="settings-section" data-name="data-exports-admin">
     <h3>{{t "Data exports" }}
-        <a href="/help/export-your-organization" target="_blank">
-            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-        </a>
+        {{> ../help_link_widget link="/help/export-your-organization" }}
     </h3>
     <p>
         {{t 'Exports all users, settings, and all data visible in public streams.' }}
diff --git a/static/templates/settings/deactivated_users_admin.hbs b/static/templates/settings/deactivated_users_admin.hbs
index 48ad6657f1..a9f2aaaebb 100644
--- a/static/templates/settings/deactivated_users_admin.hbs
+++ b/static/templates/settings/deactivated_users_admin.hbs
@@ -1,8 +1,6 @@
 <div id="admin-deactivated-users-list" class="settings-section" data-name="deactivated-users-admin">
     <h3 class="inline-block">{{t "Deactivated users" }}
-        <a href="/help/deactivate-or-reactivate-a-user" target="_blank">
-            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-        </a>
+        {{> ../help_link_widget link="/help/deactivate-or-reactivate-a-user" }}
     </h3>
     <input type="text" class="search" placeholder="{{t 'Filter deactivated users' }}" aria-label="{{t 'Filter deactivated users' }}"/>
     <div class="alert-notification" id="deactivated-user-field-status"></div>
diff --git a/static/templates/settings/display_settings.hbs b/static/templates/settings/display_settings.hbs
index dbfdeeb8c1..310c43b98e 100644
--- a/static/templates/settings/display_settings.hbs
+++ b/static/templates/settings/display_settings.hbs
@@ -31,9 +31,7 @@
 
             <div class="input-group">
                 <label for="demote_inactive_streams" class="dropdown-title">{{t "Demote inactive streams" }}
-                    <a href="/help/manage-inactive-streams" target="_blank">
-                        <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                    </a>
+                    {{> ../help_link_widget link="/help/manage-inactive-streams" }}
                 </label>
                 <select name="demote_inactive_streams" id="demote_inactive_streams">
                     {{> dropdown_options_widget option_values=demote_inactive_streams_values}}
diff --git a/static/templates/settings/organization_permissions_admin.hbs b/static/templates/settings/organization_permissions_admin.hbs
index af2c4b6aae..de012e712e 100644
--- a/static/templates/settings/organization_permissions_admin.hbs
+++ b/static/templates/settings/organization_permissions_admin.hbs
@@ -34,9 +34,7 @@
                 <div class="input-group">
                     <label for="realm_waiting_period_setting" class="dropdown-title">
                         {{t "Waiting period before new members turn into full members" }}
-                        <a href="/help/restrict-permissions-of-new-members" target="_blank">
-                            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                        </a>
+                        {{> ../help_link_widget link="/help/restrict-permissions-of-new-members" }}
                     </label>
                     <select name="realm_waiting_period_setting" id="id_realm_waiting_period_setting" class="prop-element">
                         <option value="none">{{t "None" }}</option>
@@ -81,9 +79,7 @@
             </div>
             <div class="input-group">
                 <label for="realm_email_address_visibility">{{t "Who can access user email addresses" }}
-                    <a href="/help/restrict-visibility-of-email-addresses" target="_blank">
-                        <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                    </a>
+                    {{> ../help_link_widget link="/help/restrict-visibility-of-email-addresses" }}
                 </label>
                 <select name="realm_email_address_visibility" class="setting-widget prop-element" id="id_realm_email_address_visibility" data-setting-widget-type="number">
                     {{> dropdown_options_widget option_values=email_address_visibility_values}}
@@ -142,9 +138,7 @@
 
                 <div class="input-group">
                     <label for="realm_private_message_policy">{{t "Who can use private messages" }} ({{t "beta" }})
-                        <a href="/help/restrict-private-messages" target="_blank">
-                            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                        </a>
+                        {{> ../help_link_widget link="/help/restrict-private-messages" }}
                     </label>
                     <select name="realm_private_message_policy" class="setting-widget prop-element" id="id_realm_private_message_policy" data-setting-widget-type="number">
                         {{> dropdown_options_widget option_values=private_message_policy_values}}
diff --git a/static/templates/settings/organization_profile_admin.hbs b/static/templates/settings/organization_profile_admin.hbs
index 54f48268f1..5c601a7abe 100644
--- a/static/templates/settings/organization_profile_admin.hbs
+++ b/static/templates/settings/organization_profile_admin.hbs
@@ -5,9 +5,7 @@
         <div id="org-org-profile" class="org-subsection-parent">
             <div class="subsection-header">
                 <h3>{{t "Organization profile" }}
-                    <a href="/help/create-your-organization-profile" target="_blank">
-                        <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                    </a>
+                    {{> ../help_link_widget link="/help/create-your-organization-profile" }}
                 </h3>
                 {{> settings_save_discard_widget section_name="org-profile" }}
             </div>
@@ -54,9 +52,7 @@
 
         <div class="subsection-header">
             <h3>{{t "Organization logo" }}
-                <a href="/help/create-your-organization-profile#add-a-wide-logo" target="_blank">
-                    <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                </a>
+                {{> ../help_link_widget link="/help/create-your-organization-profile#add-a-wide-logo" }}
             </h3>
             {{> upgrade_tip_widget }}
         </div>
diff --git a/static/templates/settings/organization_settings_admin.hbs b/static/templates/settings/organization_settings_admin.hbs
index 4e79541313..133c64a8cd 100644
--- a/static/templates/settings/organization_settings_admin.hbs
+++ b/static/templates/settings/organization_settings_admin.hbs
@@ -4,9 +4,7 @@
         <div id="org-msg-editing" class="org-subsection-parent">
             <div class="subsection-header">
                 <h3>{{t "Message editing" }}
-                    <a href="/help/configure-message-editing-and-deletion" target="_blank">
-                        <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                    </a>
+                    {{> ../help_link_widget link="/help/configure-message-editing-and-deletion" }}
                 </h3>
                 {{> settings_save_discard_widget section_name="msg-editing" }}
             </div>
diff --git a/static/templates/settings/settings_checkbox.hbs b/static/templates/settings/settings_checkbox.hbs
index dd0ede073e..8047cd3010 100644
--- a/static/templates/settings/settings_checkbox.hbs
+++ b/static/templates/settings/settings_checkbox.hbs
@@ -8,9 +8,7 @@
     <label for="{{prefix}}{{setting_name}}" class="inline-block" id="{{prefix}}{{setting_name}}_label">
         {{{label}}}
         {{#if help_link}}
-        <a href="{{help_link}}" target="_blank">
-            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-        </a>
+        {{> ../help_link_widget link=help_link }}
         {{/if}}
     </label>
 </div>
diff --git a/static/templates/stream_types.hbs b/static/templates/stream_types.hbs
index f0fc7d8414..0ab2d26b03 100644
--- a/static/templates/stream_types.hbs
+++ b/static/templates/stream_types.hbs
@@ -1,8 +1,6 @@
 <ul class="grey-box">
     <h4>{{t 'Who can access the stream?'}}
-        <a href="/help/stream-permissions" target="_blank">
-            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-        </a>
+        {{> help_link_widget link="/help/stream-permissions" }}
     </h4>
     <li>
         <label class="radio">
@@ -23,9 +21,7 @@
         </label>
     </li>
     <h4>{{t 'Who can post to the stream?'}}
-        <a href="/help/stream-sending-policy" target="_blank">
-            <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-        </a>
+        {{> help_link_widget link="/help/stream-sending-policy" }}
     </h4>
     {{#each stream_post_policy_values}}
     <li>
diff --git a/static/templates/subscription_settings.hbs b/static/templates/subscription_settings.hbs
index 8db33ec369..b83832cd01 100644
--- a/static/templates/subscription_settings.hbs
+++ b/static/templates/subscription_settings.hbs
@@ -67,9 +67,7 @@
             <div class="stream-email-box" {{#unless sub.email_address}}style="display: none;"{{/unless}}>
                 <label class="sub_settings_title">
                     {{t "Email address" }}
-                    <a href="/help/message-a-stream-by-email" target="_blank">
-                        <i class="fa fa-question-circle-o" aria-hidden="true"></i>
-                    </a>
+                    {{> help_link_widget link="/help/message-a-stream-by-email" }}
                 </label>
                 <div class="stream-email">
                     <span class="email-address">{{sub.email_address}}</span>