paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer_lib: Remove jQuery dependency from pm_recipient.set.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-03-12 14:12:51 -08:00
committed by Steve Howell
parent d8af33d24e
commit 4434e2c687
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
frontend_tests/puppeteer_lib/common.ts
View File

@@ -22,20 +22,16 @@ class CommonUtils {
// a flake where the typeahead doesn't show up.
await page.type("#private_message_recipient", recipient, {delay: 100});
// We use jQuery here because we need to use it's :visible
// pseudo selector to actually wait for typeahead item that
// is visible; there can be typeahead item with this selector
// that is invisible because it is meant for something else
// e.g. private message input typeahead is different from topic
// input typeahead but both can be present in the dom.
await page.waitForFunction(() => {
const selector = ".typeahead-menu .active a:visible";
return $(selector).length !== 0;
});
await page.evaluate(() => {
$(".typeahead-menu .active a:visible").trigger("click");
});
// We use [style*="display: block"] here to distinguish
// the visible typeahead menu from the invisible ones
// meant for something else; e.g., the private message
// input typeahead is different from the topic input
// typeahead but both can be present in the DOM.
const entry = await page.waitForSelector(
'.typeahead[style*="display: block"] .active a',
{visible: true},
);
await entry!.click();
},
async expect(page: Page, expected: string): Promise<void> {