paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 21:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_settings: Fix "Advanced configurations" always enabled.

Browse Source 
This new section was added in ea2d92d934.
This bug caused settings in this section to not be disabled even when
the user lacked permissions to be able to change these settings.
This commit is contained in:
tnmkr
2024-06-19 19:54:32 +05:30
committed by Tim Abbott
parent 58d91de1d6
commit 4563fe07bc
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/stream_ui_updates.js
View File

@@ -252,6 +252,13 @@ export function enable_or_disable_permission_settings_in_edit_panel(sub) {
const $general_settings_container = $stream_settings.find($("#stream_permission_settings")); const $general_settings_container = $stream_settings.find($("#stream_permission_settings"));
$general_settings_container $general_settings_container
.find("input, button")
.prop("disabled", !sub.can_change_stream_permissions);
const $advanced_configurations_container = $stream_settings.find(
$("#stream-advanced-configurations"),
);
$advanced_configurations_container
.find("input, select, button") .find("input, select, button")
.prop("disabled", !sub.can_change_stream_permissions); .prop("disabled", !sub.can_change_stream_permissions);

2
web/templates/stream_settings/stream_types.hbs
View File

@@ -43,7 +43,7 @@
</div> </div>
</div> </div>
<div class="advanced-configurations-container stream-permissions {{#if is_stream_edit}}settings-subsection-parent{{/if}}"> <div id="stream-advanced-configurations" class="advanced-configurations-container stream-permissions {{#if is_stream_edit}}settings-subsection-parent{{/if}}">
<div class="advance-config-title-container {{#if is_stream_edit}}subsection-header{{/if}}"> <div class="advance-config-title-container {{#if is_stream_edit}}subsection-header{{/if}}">
<i class="fa fa-sm fa-caret-right toggle-advanced-configurations-icon" aria-hidden="true"></i> <i class="fa fa-sm fa-caret-right toggle-advanced-configurations-icon" aria-hidden="true"></i>
<h4 class="stream_setting_subsection_title"><span>{{t 'Advanced configurations' }}</span></h4> <h4 class="stream_setting_subsection_title"><span>{{t 'Advanced configurations' }}</span></h4>