From 4597fdae2760dacf50df0226a095ba41145d2887 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Sun, 15 Jan 2017 07:24:49 -0800 Subject: [PATCH] refactor: Change params to update_count_in_dom(). We now just pass in unread_count_elem and count to update_count_in_dom(), and it does the work of finding count_span and value_span now. --- static/js/stream_list.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/static/js/stream_list.js b/static/js/stream_list.js index 77b07dc244..50c79d21ac 100644 --- a/static/js/stream_list.js +++ b/static/js/stream_list.js @@ -291,7 +291,10 @@ exports.get_stream_li = function (stream_name) { return get_filter_li('stream', stream_name); }; -function update_count_in_dom(count_span, value_span, count) { +function update_count_in_dom(unread_count_elem, count) { + var count_span = unread_count_elem.find('.count'); + var value_span = count_span.find('.value'); + if (count === 0) { count_span.hide(); if (count_span.parent().hasClass("subscription_block")) { @@ -310,9 +313,8 @@ function update_count_in_dom(count_span, value_span, count) { } function set_count(type, name, count) { - var count_span = get_filter_li(type, name).find('.count'); - var value_span = count_span.find('.value'); - update_count_in_dom(count_span, value_span, count); + var unread_count_elem = get_filter_li(type, name); + update_count_in_dom(unread_count_elem, count); } function rebuild_recent_topics(stream) {