From 45fdfcd6d4dec99475efd1172f99893b62e4d9df Mon Sep 17 00:00:00 2001 From: Zixuan James Li Date: Wed, 28 Dec 2022 15:28:52 +0800 Subject: [PATCH] typeahead: Remove default value for triage. "get_item"'s default value is not type-safe as we require its return value to always be a "string". Note that since the mobile app does not rely on this function directly, it is sufficient to only refactor the web app for this transition. Signed-off-by: Zixuan James Li --- static/js/search_suggestion.js | 2 +- static/js/typeahead_helper.js | 2 +- static/shared/js/typeahead.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/static/js/search_suggestion.js b/static/js/search_suggestion.js index 0d3ac9892a..035118382f 100644 --- a/static/js/search_suggestion.js +++ b/static/js/search_suggestion.js @@ -112,7 +112,7 @@ function get_stream_suggestions(last, operators) { streams = streams.filter((stream) => stream_matches_query(stream, query)); - streams = typeahead_helper.sorter(query, streams); + streams = typeahead_helper.sorter(query, streams, (x) => x); const regex = typeahead_helper.build_highlight_regex(query); const highlight_query = typeahead_helper.highlight_with_escaping_and_regex; diff --git a/static/js/typeahead_helper.js b/static/js/typeahead_helper.js index af615e6908..232cded475 100644 --- a/static/js/typeahead_helper.js +++ b/static/js/typeahead_helper.js @@ -287,7 +287,7 @@ function retain_unique_language_aliases(matches) { } export function sort_languages(matches, query) { - const results = typeahead.triage(query, matches); + const results = typeahead.triage(query, matches, (x) => x); // Languages that start with the query results.matches = results.matches.sort(compare_by_popularity); diff --git a/static/shared/js/typeahead.js b/static/shared/js/typeahead.js index 81c5472433..d05fd85153 100644 --- a/static/shared/js/typeahead.js +++ b/static/shared/js/typeahead.js @@ -91,7 +91,7 @@ export function get_emoji_matcher(query) { }; } -export function triage(query, objs, get_item = (x) => x) { +export function triage(query, objs, get_item) { /* We split objs into four groups: