paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 20:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Extract message_list.append_to_view.

Browse Source
This commit is contained in:
Steve Howell
2018-05-13 21:03:16 +00:00
committed by Tim Abbott
parent 56f872507c
commit 467fe7ceec
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/message_list.js
View File

@@ -44,7 +44,8 @@ exports.MessageList.prototype = {
} }
if (bottom_messages.length > 0) { if (bottom_messages.length > 0) {
self.append(bottom_messages, opts); bottom_messages = this.data.append(bottom_messages);
self.append_to_view(bottom_messages, opts);
} }
if ((self === exports.narrowed) && !self.empty()) { if ((self === exports.narrowed) && !self.empty()) {
@@ -252,13 +253,16 @@ exports.MessageList.prototype = {
}, },
append: function MessageList_append(messages, opts) { append: function MessageList_append(messages, opts) {
opts = _.extend({delay_render: false, messages_are_new: false}, opts);
var viewable_messages = this.data.append(messages); var viewable_messages = this.data.append(messages);
this.append_to_view(viewable_messages, opts);
},
append_to_view: function (messages, opts) {
opts = _.extend({delay_render: false, messages_are_new: false}, opts);
this.num_appends += 1; this.num_appends += 1;
if (!opts.delay_render) { if (!opts.delay_render) {
this.view.append(viewable_messages, opts.messages_are_new); this.view.append(messages, opts.messages_are_new);
} }
}, },