paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

page_params: Remove bot_types field to reduce database queries.

Browse Source 
Removed `bot_types` field from page_params to reduce extra db queries
on page load and allowed bot types for the user are determined locally
instead.
This commit is contained in:
Vector73
2025-01-28 11:22:16 +00:00
committed by Tim Abbott
parent a2c3138418
commit 469bc4f442
8 changed files with 56 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/lib/home.py
View File

@@ -49,22 +49,6 @@ def get_furthest_read_time(user_profile: UserProfile | None) -> float | None:
return calendar.timegm(user_activity.last_visit.utctimetuple())
def get_bot_types(user_profile: UserProfile | None) -> list[dict[str, object]]:
bot_types: list[dict[str, object]] = []
if user_profile is None:
return bot_types
for type_id, name in UserProfile.BOT_TYPES.items():
bot_types.append(
dict(
type_id=type_id,
name=name,
allowed=type_id in user_profile.allowed_bot_types,
)
)
return bot_types
def promote_sponsoring_zulip_in_realm(realm: Realm) -> bool:
if not settings.PROMOTE_SPONSORING_ZULIP:
return False
@@ -215,7 +199,7 @@ def build_page_params_for_home_page_load(
## Misc. extra data.
language_list=get_language_list(),
furthest_read_time=furthest_read_time,
bot_types=get_bot_types(user_profile),
embedded_bots_enabled=settings.EMBEDDED_BOTS_ENABLED,
two_fa_enabled=two_fa_enabled,
apps_page_url=get_apps_page_url(),
show_billing=billing_info.show_billing,