paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_ui_updates: Add generic initialize_disable_btn_hint_popover func.

Browse Source
This commit is contained in:
Yashashvi Dave
2019-05-08 11:54:06 +05:30
committed by Tim Abbott
parent a259b29322
commit 46f45f35d2
2 changed files with 20 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
static/js/stream_ui_updates.js
View File

@@ -16,34 +16,39 @@ exports.update_check_button_for_sub = function (sub) {
} }
}; };
exports.initialize_cant_subscribe_popover = function (sub) { exports.initialize_disable_btn_hint_popover = function (btn_wrapper, popover_btn,
var button_wrapper = stream_edit.settings_for_sub(sub).find('.sub_unsub_button_wrapper'); disabled_btn, hint_text) {
var settings_button = subs.settings_button_for_sub(sub);
// Disabled button blocks mouse events(hover) from reaching // Disabled button blocks mouse events(hover) from reaching
// to it's parent div element, so popover don't get triggered. // to it's parent div element, so popover don't get triggered.
// Add css to prevent this. // Add css to prevent this.
settings_button.css("pointer-events", "none"); disabled_btn.css("pointer-events", "none");
settings_button.popover({ popover_btn.popover({
placement: "bottom", placement: "bottom",
content: "<div class='cant_subscribe_hint'>%s</div>".replace( content: "<div class='sub_disable_btn_hint'>%s</div>".replace(
'%s', i18n.t('Only existing subscribers can add users to private streams.')), '%s', hint_text),
trigger: "manual", trigger: "manual",
html: true, html: true,
animation: false, animation: false,
}); });
button_wrapper.on('mouseover', function (e) { btn_wrapper.on('mouseover', function (e) {
settings_button.popover('show'); popover_btn.popover('show');
e.stopPropagation(); e.stopPropagation();
}); });
button_wrapper.on('mouseout', function (e) { btn_wrapper.on('mouseout', function (e) {
settings_button.popover('hide'); popover_btn.popover('hide');
e.stopPropagation(); e.stopPropagation();
}); });
}; };
exports.initialize_cant_subscribe_popover = function (sub) {
var button_wrapper = stream_edit.settings_for_sub(sub).find('.sub_unsub_button_wrapper');
var settings_button = subs.settings_button_for_sub(sub);
exports.initialize_disable_btn_hint_popover(button_wrapper, settings_button, settings_button,
i18n.t("Only stream members can add users to a private stream"));
};
exports.update_settings_button_for_sub = function (sub) { exports.update_settings_button_for_sub = function (sub) {
var settings_button = subs.settings_button_for_sub(sub); var settings_button = subs.settings_button_for_sub(sub);
if (sub.subscribed) { if (sub.subscribed) {
@@ -199,26 +204,8 @@ exports.update_add_subscriptions_elements = function (sub) {
input_element.attr("disabled", "disabled"); input_element.attr("disabled", "disabled");
button_element.attr("disabled", "disabled"); button_element.attr("disabled", "disabled");
// Disabled button blocks mouse events(hover) from reaching exports.initialize_disable_btn_hint_popover($('.add_subscribers_container'), input_element, button_element,
// to it's parent div element, so popover don't get triggered. i18n.t("Only stream members can add users to a private stream"));
// Add css to prevent this.
button_element.css("pointer-events", "none");
$('.add_subscribers_container input').popover({
placement: "bottom",
content: "<div class='cant_add_subs_hint'>%s</div>".replace(
'%s', i18n.t('Only stream subscribers can add users to a private stream.')),
trigger: "manual",
html: true,
animation: false});
$('.add_subscribers_container').on('mouseover', function (e) {
$('.add_subscribers_container input').popover('show');
e.stopPropagation();
});
$('.add_subscribers_container').on('mouseout', function (e) {
$('.add_subscribers_container input').popover('hide');
e.stopPropagation();
});
} }
}; };

3
static/styles/popovers.scss
View File

@@ -337,8 +337,7 @@ ul.remind_me_popover .remind_icon {
top: 1px; top: 1px;
} }
.popover .cant_subscribe_hint, .popover .sub_disable_btn_hint {
.popover .cant_add_subs_hint {
padding-left: 5px; padding-left: 5px;
padding-right: 5px; padding-right: 5px;
font-size: small; font-size: small;