paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

left_sidebar: Avoid selecting header as first row when searching.

Browse Source
This commit is contained in:
Aman Agrawal
2025-08-30 10:53:44 +05:30
committed by Tim Abbott
parent a4c2327fa9
commit 478ea89506
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/e2e-tests/message-basics.test.ts
View File

@@ -329,10 +329,6 @@ async function test_stream_search_filters_stream_list(page: Page): Promise<void>
// Enter the search box and test highlighted suggestion // Enter the search box and test highlighted suggestion
await page.click(".left-sidebar-search-input"); await page.click(".left-sidebar-search-input");
await page.waitForSelector("#views-label-container.highlighted_row", {visible: true});
await arrow(page, "Down");
await page.waitForSelector(".top_left_inbox.top_left_row.highlighted_row", {visible: true}); await page.waitForSelector(".top_left_inbox.top_left_row.highlighted_row", {visible: true});
await page.waitForSelector((await get_stream_li(page, "Verona")) + " .highlighted_row", { await page.waitForSelector((await get_stream_li(page, "Verona")) + " .highlighted_row", {

3
web/src/sidebar_ui.ts
View File

@@ -539,7 +539,8 @@ export function initialize_left_sidebar_cursor(): void {
if ($all_rows.length === 0) { if ($all_rows.length === 0) {
return undefined; return undefined;
} }
return $all_rows.first(); const $non_header_rows = $all_rows.not($(get_header_rows_selectors()));
return $non_header_rows.first();
}, },
next_key($key) { next_key($key) {
const $all_rows = all_rows(); const $all_rows = all_rows();