paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

alert_words_ui test: Avoid bizarre idioms.

Browse Source 
We now just do the following in the mocking:

    - capture which items are passed into the list
      widget

    - simulate the call to modifier_html to exercise
      the template rendering
This commit is contained in:
Steve Howell
2025-01-07 15:23:22 +00:00
committed by Tim Abbott
parent fd802e74ce
commit 47b4b4a506
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
web/tests/alert_words_ui.test.cjs
View File

@@ -19,26 +19,29 @@ alert_words.initialize({
run_test("rerender_alert_words_ui", ({mock_template}) => { run_test("rerender_alert_words_ui", ({mock_template}) => {
let list_widget_create_called = false; let list_widget_create_called = false;
alert_words_ui.reset(); alert_words_ui.reset();
const ListWidget = mock_esm("../src/list_widget", {
modifier_html: noop, mock_esm("../src/list_widget", {
create(_container, words, opts) { create(_container, words, opts) {
const alert_words = []; assert.deepEqual(words, [{word: "foo"}, {word: "bar"}]);
ListWidget.modifier_html = opts.modifier_html;
for (const word of words) { for (const word of words) {
alert_words.push(opts.modifier_html(word)); opts.modifier_html(word);
} }
list_widget_create_called = true; list_widget_create_called = true;
return alert_words;
}, },
generic_sort_functions: noop, generic_sort_functions: noop,
}); });
mock_template("settings/alert_word_settings_item.hbs", false, (args) => { mock_template("settings/alert_word_settings_item.hbs", false, (args) => {
assert.ok(["foo", "bar"].includes(args.alert_word.word)); assert.ok(["foo", "bar"].includes(args.alert_word.word));
}); });
assert.equal(alert_words_ui.loaded, false); assert.equal(alert_words_ui.loaded, false);
alert_words_ui.rerender_alert_words_ui();
assert.equal(list_widget_create_called, false); assert.equal(list_widget_create_called, false);
// Invoke list_widget.create indirectly via these calls.
alert_words_ui.rerender_alert_words_ui();
alert_words_ui.set_up_alert_words(); alert_words_ui.set_up_alert_words();
assert.equal(alert_words_ui.loaded, true); assert.equal(alert_words_ui.loaded, true);
assert.equal(list_widget_create_called, true); assert.equal(list_widget_create_called, true);
}); });