paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ajax request tracking and aborting to channel

Browse Source 
The channel module now keeps track pending ajax requests and has an
abort_all function to angle all pending requests.

(imported from commit 4e78ab24d2295bd67de5633e3a200dfa489825b1)
This commit is contained in:
Jason Michalski
2014-02-06 22:27:16 -05:00
parent 233cfc2593
commit 47ca6b2800
2 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
static/js/channel.js
View File

@@ -1,6 +1,22 @@
var channel = (function () {
var exports = {};
var pending_requests = [];
function add_pending_request (jqXHR) {
pending_requests.push(jqXHR);
if (pending_requests.length > 50) {
blueslip.warn('The length of pending_requests is over 50. Most likely ' +
'they are not being correctly removed.');
}
}
function remove_pending_request (jqXHR) {
var pending_request_index = _.indexOf(pending_requests, jqXHR)
if (pending_request_index != -1){
pending_requests.splice(pending_request_index, 1);
}
}
function call(args, idempotent) {
// Wrap the error handlers to reload the page if we get a CSRF error
@@ -10,6 +26,8 @@ function call(args, idempotent) {
orig_error = function () {};
}
args.error = function wrapped_error(xhr, error_type, xhn) {
remove_pending_request(xhr);
if (xhr.status === 403 && $.parseJSON(xhr.responseText).msg.indexOf("CSRF Error:") !== -1) {
reload.initiate({immediate: true});
}
@@ -20,20 +38,31 @@ function call(args, idempotent) {
orig_success = function () {};
}
args.success = function wrapped_success(data, textStatus, jqXHR) {
remove_pending_request(jqXHR);
if (!data && idempotent) {
// If idempotent, retry
blueslip.log("Retrying idempotent" + args);
setTimeout(function () {
$.ajax(args);
var jqXHR = $.ajax(args);
add_pending_request(jqXHR);
}, 0);
return;
}
return orig_success(data, textStatus, jqXHR);
};
return $.ajax(args);
var jqXHR = $.ajax(args);
add_pending_request(jqXHR);
return jqXHR;
}
exports.abort_all = function () {
_.each(pending_requests, function (jqXHR) {
jqXHR.abort();
});
};
exports.get = function (options) {
var args = _.extend({type: "GET", dataType: "json"}, options);
return call(args, options.idempotent);