paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: Move update_user_data() down in file.

Browse Source 
This is just a lexical change.  We are going
to use some shared code soon that we don't want
to export, and if `update_user_data()` is
declared too early in the file, then the function
we extract will either need to be exported (to
satisy the linter) or placed far away from its
most natural siblings.
This commit is contained in:
Steve Howell
2020-05-11 10:42:36 +00:00
committed by Tim Abbott
parent 91fa64e8e6
commit 47f07eeb2e
1 changed files with 32 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
static/js/settings_users.js
View File

@@ -127,39 +127,6 @@ function get_status_field() {
}
}
exports.update_user_data = function (user_id, new_data) {
if (!meta.loaded) {
return;
}
const user_row = get_user_info_row(user_id);
if (new_data.full_name !== undefined) {
// Update the full name in the table
user_row.find(".user_name").text(new_data.full_name);
}
if (new_data.owner !== undefined) {
// Update the bot owner in the table
user_row.find(".owner").text(new_data.owner);
}
if (new_data.is_active !== undefined) {
if (new_data.is_active === false) {
// Deactivate the user/bot in the table
update_view_on_deactivate(user_row);
} else {
// Reactivate the user/bot in the table
update_view_on_reactivate(user_row);
}
}
if (new_data.is_admin !== undefined || new_data.is_guest !== undefined) {
user_row.find(".user_role").text(people.get_user_type(user_id));
}
};
function failed_listing_users(xhr) {
loading.destroy_indicator($('#subs_page_loading_indicator'));
const status = get_status_field();
@@ -353,6 +320,38 @@ section.deactivated.create_table = (deactivated_users) => {
$("#admin_deactivated_users_table").show();
};
exports.update_user_data = function (user_id, new_data) {
if (!meta.loaded) {
return;
}
const user_row = get_user_info_row(user_id);
if (new_data.full_name !== undefined) {
// Update the full name in the table
user_row.find(".user_name").text(new_data.full_name);
}
if (new_data.owner !== undefined) {
// Update the bot owner in the table
user_row.find(".owner").text(new_data.owner);
}
if (new_data.is_active !== undefined) {
if (new_data.is_active === false) {
// Deactivate the user/bot in the table
update_view_on_deactivate(user_row);
} else {
// Reactivate the user/bot in the table
update_view_on_reactivate(user_row);
}
}
if (new_data.is_admin !== undefined || new_data.is_guest !== undefined) {
user_row.find(".user_role").text(people.get_user_type(user_id));
}
};
function start_data_load() {
loading.make_indicator($('#admin_page_users_loading_indicator'), {text: 'Loading...'});
loading.make_indicator($('#admin_page_bots_loading_indicator'), {text: 'Loading...'});