paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue where arrowing-down near end of page would skip a message.

Browse Source 
We had this fascinating behavior where pressing a down arrow near the
end of the page would advance the pointer, call recenter_view, which
would trigger a scroll event, which would call keep_pointer_in_view,
which would notice that we were at the end of the page and advance the
pointer again!

I split out that last part into its own function which is only called
on mousewheel events.

(imported from commit bc85443e762356e3055f8f88585940a1f11f9124)
This commit is contained in:
Waseem Daher
2012-10-10 14:20:31 -04:00
parent a0bb0d257b
commit 48cda57d84
3 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
zephyr/static/js/ui.js
View File

@@ -138,9 +138,15 @@ $(function () {
sub_from_home(compose_class_name(), $('#class-nosub'));
});
var throttled_scrollhandler = $.throttle(50, function() {
var throttled_scrollhandler = $.throttle(50, function(e) {
if ($('#home').hasClass('active')) {
keep_pointer_in_view();
keep_pointer_in_view();
if (e.type === 'mousewheel') {
// If we mousewheel (or trackpad-scroll) when
// we're at the top and bottom of the page, the
// pointer may still want to move.
move_pointer_at_page_top_and_bottom();
}
}
});
$(window).mousewheel(throttled_scrollhandler);