From 48d99886fd409adf5ae448a01c4d25ca653cc3b2 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 16 Apr 2021 09:58:21 -0700 Subject: [PATCH] event_queue: Update rule for when we can remove compatibility code. Since c3a8a15bae2074b93554114432167960c8c1b515 removed the last instance of code using the dictionary code path, we actually need to wait until one can no longer upgrade directly from 4.x to master in order to avoid breakage should we remove this compatibility code, since only today did we stop generating the old event format. --- zerver/tornado/event_queue.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/tornado/event_queue.py b/zerver/tornado/event_queue.py index 11512be23e..2989f2913d 100644 --- a/zerver/tornado/event_queue.py +++ b/zerver/tornado/event_queue.py @@ -1207,7 +1207,7 @@ def process_notification(notice: Mapping[str, Any]) -> None: # queue at the time of upgrade. # # TODO/compatibility: Remove this block once you can no - # longer directly upgrade directly from 3.x to master. + # longer directly upgrade directly from 4.x to master. user_ids: List[int] = [user["id"] for user in cast(List[Mapping[str, int]], users)] else: user_ids = cast(List[int], users)