diff --git a/api_docs/changelog.md b/api_docs/changelog.md index 9352d44243..e06494901c 100644 --- a/api_docs/changelog.md +++ b/api_docs/changelog.md @@ -20,6 +20,18 @@ format used by the Zulip server that they are interacting with. ## Changes in Zulip 7.0 +**Feature level 183** + +* [`POST /register`](/api/register-queue): Removed the + `realm_community_topic_editing_limit_seconds` property, which was no + longer in use. The time limit for editing topics is controlled by the + realm setting `move_messages_within_stream_limit_seconds`, see feature + level 162. +* [`GET /events`](/api/get-events): Removed the `community_topic_editing_limit_seconds` + property from realm `update_dict` event documentation, because it was + never returned as a changed property in this event and was only ever + returned in the [`POST /register`](/api/register-queue) response. + **Feature level 182** * `POST /export/realm`: This endpoint now returns the ID of the data diff --git a/version.py b/version.py index c5c7567d5d..fdaa51fc6f 100644 --- a/version.py +++ b/version.py @@ -33,7 +33,7 @@ DESKTOP_WARNING_VERSION = "5.4.3" # Changes should be accompanied by documentation explaining what the # new level means in api_docs/changelog.md, as well as "**Changes**" # entries in the endpoint's documentation in `zulip.yaml`. -API_FEATURE_LEVEL = 182 +API_FEATURE_LEVEL = 183 # Bump the minor PROVISION_VERSION to indicate that folks should provision # only when going from an old version of the code to a newer version. Bump diff --git a/zerver/lib/events.py b/zerver/lib/events.py index 9eb875e3f6..6db628faf6 100644 --- a/zerver/lib/events.py +++ b/zerver/lib/events.py @@ -276,10 +276,6 @@ def fetch_initial_state_data( Realm.POLICY_ADMINS_ONLY if user_profile is None else realm.delete_own_message_policy ) - state[ - "realm_community_topic_editing_limit_seconds" - ] = Realm.DEFAULT_COMMUNITY_TOPIC_EDITING_LIMIT_SECONDS - # This setting determines whether to send presence and also # whether to display of users list in the right sidebar; we # want both behaviors for logged-out users. We may in the diff --git a/zerver/models.py b/zerver/models.py index 3c98a4116a..4093a95381 100644 --- a/zerver/models.py +++ b/zerver/models.py @@ -399,8 +399,6 @@ class Realm(models.Model): # type: ignore[django-manager-missing] # django-stub MOVE_MESSAGES_BETWEEN_STREAMS_POLICY_TYPES = INVITE_TO_REALM_POLICY_TYPES - DEFAULT_COMMUNITY_TOPIC_EDITING_LIMIT_SECONDS = 259200 - DEFAULT_MOVE_MESSAGE_LIMIT_SECONDS = 7 * SECONDS_PER_DAY move_messages_within_stream_limit_seconds = models.PositiveIntegerField( diff --git a/zerver/openapi/zulip.yaml b/zerver/openapi/zulip.yaml index 9dc1a6f9ff..056dae6238 100644 --- a/zerver/openapi/zulip.yaml +++ b/zerver/openapi/zulip.yaml @@ -3832,7 +3832,13 @@ paths: description: | An object containing the properties that have changed. - **Changes**: Before Zulip 6.0 (feature level 150), on changing any of + **Changes**: In Zulip 7.0 (feature level 183), the + `community_topic_editing_limit_seconds` property was removed. + It was documented as potentially returned as a changed property + in this event, but in fact it was only ever returned in the + [`POST /register`](/api/register-queue) response. + + Before Zulip 6.0 (feature level 150), on changing any of `allow_message_editing`, `message_content_edit_limit_seconds`, or `edit_topic_policy` settings, this object included all the three settings irrespective of which of these settings were changed. Now, a separate event @@ -3869,15 +3875,6 @@ paths: description: | The [policy](/api/roles-and-permissions#permission-levels) for which users can create bot users in this organization. - community_topic_editing_limit_seconds: - type: integer - description: | - Messages sent more than this many seconds ago cannot have - their topics edited by other users with this organization's - [message edit policy](/help/restrict-message-editing-and-deletion). - - **Changes**: New in Zulip 3.0 (feature level 11). Previously this - value was hardcoded to 86400 seconds (1 day). create_public_stream_policy: type: integer description: | @@ -10506,7 +10503,14 @@ paths: works, avoids clients needing to worry about large classes of potentially messy races, etc. - **Changes**: The `email_address_visibility` setting was removed in Zulip 7.0 (feature level 163). + **Changes**: Before Zulip 7.0 (feature level 183), the + `realm_community_topic_editing_limit_seconds` property + was returned by the response. It was removed because it + had not been in use since the realm setting + `move_messages_within_stream_limit_seconds` was introduced + in feature level 162. + + The `email_address_visibility` setting was removed in Zulip 7.0 (feature level 163). It was replaced by a [user setting](/api/update-settings) with a [realm user default](/api/update-realm-user-settings-defaults), with the encoding of different values preserved. Clients can support all versions by supporting the current API and treating @@ -13103,17 +13107,6 @@ paths: **Changes**: New in Zulip 7.0 (feature level 162). Previously, there was no time limit for moving messages between streams for users with permission to do so. - realm_community_topic_editing_limit_seconds: - type: integer - description: | - Present if `realm` is present in `fetch_event_types`. - - Messages sent more than this many seconds ago cannot have - their topics edited by other users with this organization's - [message edit policy](/help/restrict-message-editing-and-deletion). - - **Changes**: New in Zulip 3.0 (feature level 11). Previously this - value was hardcoded to 86400 seconds (1 day). realm_enable_read_receipts: type: boolean description: | diff --git a/zerver/tests/test_home.py b/zerver/tests/test_home.py index 3b0b4577c2..33a426dbc0 100644 --- a/zerver/tests/test_home.py +++ b/zerver/tests/test_home.py @@ -116,7 +116,6 @@ class HomeTest(ZulipTestCase): "realm_bot_creation_policy", "realm_bot_domain", "realm_bots", - "realm_community_topic_editing_limit_seconds", "realm_create_private_stream_policy", "realm_create_public_stream_policy", "realm_create_web_public_stream_policy",