paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify rendering of "more topics" link.

Browse Source 
We now use a template to render the "more topics" link.

We also remove an unnecessary conditional and an unnecessary
attribute.

Finally, our unit tests are a bit more granular now.
This commit is contained in:
Steve Howell
2017-09-21 11:44:31 -07:00
committed by Tim Abbott
parent 544bbab480
commit 490935249c
4 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/topic_list.js
View File

@@ -94,22 +94,17 @@ exports.widget = function (parent_elem, my_stream_id) {
ul.append(li);
});
// We should actually only show more topics when we're zoomed out, although
// CSS makes this fine for now.
var show_more_topics_link = true;
if (show_more_topics_link) {
var show_more = $('<li class="show-more-topics">');
show_more.attr('data-stream', my_stream_name);
var link = $('<a href="#">');
link.html(i18n.t('more topics'));
show_more.html(link);
ul.append(show_more);
}
var show_more = self.build_more_topics_section();
ul.append(show_more);
return ul;
};
self.build_more_topics_section = function () {
var show_more_html = templates.render('more_topics');
return $(show_more_html);
};
self.get_parent = function () {
return parent_elem;
};
@@ -180,8 +175,6 @@ exports.rebuild = function (stream_li, stream_id) {
exports.remove_expanded_topics();
active_widget = exports.widget(stream_li, stream_id);
active_widget.build(active_topic);
return active_widget; // used for testing
};
// For zooming, we only do topic-list stuff here...let stream_list