paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

presence: Avoid doc/naming references to "orange".

Browse Source 
It seems like orange is the loudest possible color to
denote a quasi-neutral-idle state, so we hope to
replace it with another color.

This commit does not change any styling.

I removed the sentences in the doc, since they are
kind of too vague to be useful. If we want to say that
the idle state is correlated with the half-orange
circles in the buddy list, then we want to say that
more specifically.
This commit is contained in:
Steve Howell
2022-01-27 21:22:59 +00:00
committed by Tim Abbott
parent a9ea525757
commit 498b02dfb2
4 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/subsystems/presence.md
View File

@@ -23,11 +23,10 @@ requests contains a few parameters. The most important is "status",
which had 2 valid values: which had 2 valid values:
- "active" -- this means the user has interacted with the client - "active" -- this means the user has interacted with the client
recently. We use this for the "green" state in the web app. recently.
- "idle" -- the user has not interacted with the client recently. - "idle" -- the user has not interacted with the client recently.
This is important for the case where a user left a Zulip tab open on This is important for the case where a user left a Zulip tab open on
their desktop at work and went home for the weekend. We use this their desktop at work and went home for the weekend.
for the "orange" state in the web app.
The client receives in the response to that request a data set that, The client receives in the response to that request a data set that,
for each user, contains their status and timestamp that we last heard for each user, contains their status and timestamp that we last heard

2
frontend_tests/node_tests/buddy_data.js
View File

@@ -142,7 +142,7 @@ test("user_circle, level, status_description", () => {
assert.equal(buddy_data.get_user_circle_class(me.user_id), "user_circle_green"); assert.equal(buddy_data.get_user_circle_class(me.user_id), "user_circle_green");
set_presence(fred.user_id, "idle"); set_presence(fred.user_id, "idle");
assert.equal(buddy_data.get_user_circle_class(fred.user_id), "user_circle_orange"); assert.equal(buddy_data.get_user_circle_class(fred.user_id), "user_circle_idle");
assert.equal(buddy_data.level(fred.user_id), 2); assert.equal(buddy_data.level(fred.user_id), 2);
assert.equal(buddy_data.status_description(fred.user_id), "translated: Idle"); assert.equal(buddy_data.status_description(fred.user_id), "translated: Idle");

2
static/js/buddy_data.js
View File

@@ -41,7 +41,7 @@ export function get_user_circle_class(user_id) {
case "active": case "active":
return "user_circle_green"; return "user_circle_green";
case "idle": case "idle":
return "user_circle_orange"; return "user_circle_idle";
case "away_them": case "away_them":
case "away_me": case "away_me":
return "user_circle_empty_line"; return "user_circle_empty_line";

10
static/styles/user_circles.css
View File

@@ -1,5 +1,7 @@
$idle_color: hsl(29, 84%, 51%);
.user_circle_green, .user_circle_green,
.user_circle_orange, .user_circle_idle,
.user_circle_empty, .user_circle_empty,
.user_circle_empty_line { .user_circle_empty_line {
border-radius: 50%; border-radius: 50%;
@@ -14,12 +16,12 @@
border-color: hsl(106, 74%, 44%); border-color: hsl(106, 74%, 44%);
} }
.user_circle_orange { .user_circle_idle {
border-color: hsl(29, 84%, 51%); border-color: $idle_color;
background: linear-gradient( background: linear-gradient(
to bottom, to bottom,
hsla(0, 0%, 100%, 0) 50%, hsla(0, 0%, 100%, 0) 50%,
hsla(29, 84%, 51%, 1) 50% $idle_color 50%
); );
} }