paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

integrations: Fix bug with github multiple reviews requested on PR.

Browse Source 
Fixes a bug in which multiple of the same messages are posted when
multiple reviewers are added to a PR.

Fixes #18393.
This commit is contained in:
Adam Birds
2021-05-08 02:11:09 +00:00
committed by Tim Abbott
parent 747cbb5dde
commit 49b920d33a
4 changed files with 4 additions and 991 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
zerver/webhooks/github/tests.py
View File

@@ -320,24 +320,8 @@ class GitHubWebhookTest(WebhookTestCase):
expected_message,
)
def test_pull_request_review_requested_singular_key_msg(self) -> None:
expected_message = "**eeshangarg** requested [rishig](https://github.com/rishig) for a review on [PR #6](https://github.com/eeshangarg/Scheduler/pull/6)."
self.check_webhook(
"pull_request__review_requested_singular_key",
"Scheduler / PR #6 Mention how awesome this project is in ...",
expected_message,
)
def test_pull_request_review_requested_multiple_reviwers_msg(self) -> None:
expected_message = "**eeshangarg** requested [showell](https://github.com/showell) and [timabbott](https://github.com/timabbott) for a review on [PR #1](https://github.com/eeshangarg/Scheduler/pull/1)."
self.check_webhook(
"pull_request__review_requested_multiple_reviewers",
"Scheduler / PR #1 This is just a test commit",
expected_message,
)
def test_pull_request__review_requested_team_reviewer_msg(self) -> None:
expected_message = "**singhsourabh** requested [shreyaskargit](https://github.com/shreyaskargit), [bajaj99prashant](https://github.com/bajaj99prashant), [review-team](https://github.com/orgs/test-org965/teams/review-team), [authority](https://github.com/orgs/test-org965/teams/authority) and [management](https://github.com/orgs/test-org965/teams/management) for a review on [PR #4](https://github.com/test-org965/webhook-test/pull/4)."
expected_message = "**singhsourabh** requested [authority](https://github.com/orgs/test-org965/teams/authority) for a review on [PR #4](https://github.com/test-org965/webhook-test/pull/4)."
self.check_webhook(
"pull_request__review_requested_team_reviewer",
"webhook-test / PR #4 testing webhook",