paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_control_buttons: Change class name for GIF icon.

Browse Source 
Since we no longer use giphy logo to open giphy
popover, this is a more appropriate name.
This commit is contained in:
Aman Agrawal
2021-04-29 20:40:00 +00:00
committed by Tim Abbott
parent 818b4ee7f9
commit 4a91d5ffdb
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/click_handlers.js
View File

@@ -671,7 +671,7 @@ export function initialize() {
function handle_compose_click(e) { function handle_compose_click(e) {
// Emoji clicks should be handled by their own click handler in emoji_picker.js // Emoji clicks should be handled by their own click handler in emoji_picker.js
if ($(e.target).is(".emoji_map, img.emoji, .drag, .compose_giphy_logo")) { if ($(e.target).is(".emoji_map, img.emoji, .drag, .compose_gif_icon")) {
return; return;
} }

4
static/js/giphy.js
View File

@@ -200,7 +200,7 @@ function get_popover_placement() {
export function initialize() { export function initialize() {
$("body").on("keydown", ".giphy-gif", ui_util.convert_enter_to_click); $("body").on("keydown", ".giphy-gif", ui_util.convert_enter_to_click);
$("body").on("keydown", ".compose_giphy_logo", ui_util.convert_enter_to_click); $("body").on("keydown", ".compose_gif_icon", ui_util.convert_enter_to_click);
$("body").on("click", "#giphy_search_clear", (e) => { $("body").on("click", "#giphy_search_clear", (e) => {
e.stopPropagation(); e.stopPropagation();
@@ -208,7 +208,7 @@ export function initialize() {
update_grid_with_search_term(); update_grid_with_search_term();
}); });
$("body").on("click", ".compose_giphy_logo", (e) => { $("body").on("click", ".compose_gif_icon", (e) => {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();

2
static/styles/compose.css
View File

@@ -399,7 +399,7 @@ input.recipient_box {
display: inline-block; display: inline-block;
} }
.compose_giphy_link .compose_giphy_logo { .compose_giphy_link .compose_gif_icon {
position: relative; position: relative;
font-size: 23px; font-size: 23px;
top: -4px; top: -4px;

2
static/styles/zulip.css
View File

@@ -2518,7 +2518,7 @@ div.topic_edit_spinner .loading_indicator_spinner {
top: -1px; top: -1px;
} }
.compose_giphy_logo { .compose_gif_icon {
top: 6px; top: 6px;
} }
} }

2
static/templates/compose_control_buttons.hbs
View File

@@ -7,7 +7,7 @@
<a role="button" class="compose_control_button fa fa-video-camera video_link" aria-label="{{t 'Add video call' }}" tabindex=0 title="{{t 'Add video call' }}"></a> <a role="button" class="compose_control_button fa fa-video-camera video_link" aria-label="{{t 'Add video call' }}" tabindex=0 title="{{t 'Add video call' }}"></a>
<a role="button" class="compose_control_button fa fa-smile-o emoji_map" aria-label="{{t 'Add emoji' }}" tabindex=0 title="{{t 'Add emoji' }}"></a> <a role="button" class="compose_control_button fa fa-smile-o emoji_map" aria-label="{{t 'Add emoji' }}" tabindex=0 title="{{t 'Add emoji' }}"></a>
<a role="button" class="compose_control_button compose_giphy_link {{#unless giphy_enabled }} hide {{/unless}}" aria-label="{{t 'Add GIF' }}" title="{{t 'Add GIF' }}"> <a role="button" class="compose_control_button compose_giphy_link {{#unless giphy_enabled }} hide {{/unless}}" aria-label="{{t 'Add GIF' }}" title="{{t 'Add GIF' }}">
<i class="compose_giphy_logo zulip-icon zulip-icon-gif" tabindex=0></i> <i class="compose_gif_icon zulip-icon zulip-icon-gif" tabindex=0></i>
</a> </a>
{{#unless hide_drafts_link}} {{#unless hide_drafts_link}}
<a class="message-control-link drafts-link" href="#drafts" title="{{t 'Drafts' }} (d)">{{t 'Drafts' }}</a> <a class="message-control-link drafts-link" href="#drafts" title="{{t 'Drafts' }} (d)">{{t 'Drafts' }}</a>