Make "assert" global in the node tests.

In the early days of the node tests we didn't have an index.js
driver, so each test set it up its own environment.  That ship
has long since sailed, so now we just require assert in index.js
as a global and make it so that the linter doesn't complain.

(imported from commit 1ded3d330ff40603cf4dd7c5578f6a47088d7cc8)

tools/jslint/check-all.js

@@ -128,7 +128,7 @@ process.argv.forEach(function (filepath) {
         if (filepath.indexOf('zerver/tests/frontend/') !== -1) {
             // Include '$' and browser globals because we use them inside
             // casper.evaluate
-            options.predef = ['casper', '$', 'document', 'window', 'set_global', 'add_dependencies'];
+            options.predef = ['casper', '$', 'document', 'window', 'set_global', 'add_dependencies', 'assert'];
         } else {
             options.predef = [];
         }

zerver/tests/frontend/node/activity.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 set_global('$', function () {
     return {
         on: function () {

zerver/tests/frontend/node/alert_words.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 set_global('page_params', {
     alert_words: ['alertone', 'alerttwo', 'alertthree', 'al*rt.*s', '.+'],
     email: 'tester@zulip.com'

zerver/tests/frontend/node/composebox_typeahead.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 var ct = require('js/composebox_typeahead.js');
 
 var people_in_realm = [{email: 'othello@zulip.com', full_name: "Othello, Moor of Venice"},

zerver/tests/frontend/node/dict.js

@@ -1,8 +1,6 @@
 var _ = global._;
 var Dict = global.Dict;
 
-var assert = require('assert');
-
 set_global('blueslip', {});
 
 (function test_basic() {

zerver/tests/frontend/node/echo.js

@@ -1,5 +1,4 @@
 /*global Dict */
-var assert = require('assert');
 var path = require('path');
 var fs = require('fs');
 

zerver/tests/frontend/node/filter.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 add_dependencies({
     util: 'js/util.js',
     stream_data: 'js/stream_data.js'

zerver/tests/frontend/node/index.js

@@ -1,3 +1,4 @@
+global.assert = require('assert');
 var fs = require('fs');
 var Handlebars = require('handlebars');
 

zerver/tests/frontend/node/message_list.js

@@ -2,8 +2,6 @@
 // aspects of the MessageList class.  We have to stub out a few functions
 // related to views and events to get the tests working.
 
-var assert = require('assert');
-
 add_dependencies({
     util: 'js/util.js',
     muting: 'js/muting.js',

zerver/tests/frontend/node/muting.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 set_global('page_params', {
     domain: 'zulip.com'
 });

zerver/tests/frontend/node/narrow.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 add_dependencies({
     stream_data: 'js/stream_data.js',
     Filter: 'js/filter.js'

zerver/tests/frontend/node/people.js

@@ -1,4 +1,3 @@
-var assert = require('assert');
 var people = require("js/people.js");
 
 set_global('page_params', {

zerver/tests/frontend/node/search_suggestion.js

@@ -5,8 +5,6 @@
 // clean up after themselves, and they should explicitly stub all
 // dependencies.
 
-var assert = require('assert');
-
 add_dependencies({
     util: 'js/util.js',
     Handlebars: 'handlebars',

zerver/tests/frontend/node/stream_color.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 set_global('$', function (f) {});
 
 var stream_color = require('js/stream_color.js');

zerver/tests/frontend/node/stream_data.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 add_dependencies({
     stream_color: 'js/stream_color.js'
 });

zerver/tests/frontend/node/stream_list.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 set_global('$', function () {});
 
 add_dependencies({

zerver/tests/frontend/node/templates.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 add_dependencies({
     Handlebars: 'handlebars',
     templates: 'js/templates'

zerver/tests/frontend/node/unread.js

@@ -21,7 +21,6 @@ set_global('stream_data', stream_data);
 var Dict = global.Dict;
 var muting = global.muting;
 var unread = require('js/unread.js');
-var assert = require('assert');
 
 var narrow = {};
 global.narrow = narrow;

zerver/tests/frontend/node/util.js

@@ -1,5 +1,3 @@
-var assert = require('assert');
-
 add_dependencies({
     util: 'js/util.js'
 });