paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename "clear_search_button" to "old_clear_search_button".

Browse Source 
This temporary change allows us to preserve these old styles
while iteratively move all the close buttons to new styles.
Once the migration is complete, `old_clear_search_button` won't
exist anymore and there will be new styles for `clear_search_button`.
This commit is contained in:
Harsh
2024-12-15 21:16:52 +05:30
committed by Tim Abbott
parent 31b3842c9b
commit 4b5e578b9f
12 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/styles/app_components.css
View File

@@ -402,7 +402,7 @@ input.settings_text_input {
should be replaced with a Zulip icon, should be replaced with a Zulip icon,
and its formatting should have no extra and its formatting should have no extra
space around its viewbox in SVG. */ space around its viewbox in SVG. */
.clear_search_button { .old_clear_search_button {
&:hover { &:hover {
color: var(--color-text-clear-search-button-hover); color: var(--color-text-clear-search-button-hover);
} }

4
web/styles/left_sidebar.css
View File

@@ -84,7 +84,7 @@
.topic_search_section { .topic_search_section {
margin: 3px 0; margin: 3px 0;
.clear_search_button { .old_clear_search_button {
grid-area: clear-button; grid-area: clear-button;
/* Override app-component positioning. */ /* Override app-component positioning. */
position: static; position: static;
@@ -1745,7 +1745,7 @@ li.topic-list-item {
padding-right: 30px; padding-right: 30px;
} }
.clear_search_button { .old_clear_search_button {
/* Use the border-box model so flex /* Use the border-box model so flex
can do its thing despite whatever can do its thing despite whatever
padding and border we specify. */ padding and border we specify. */

2
web/styles/recent_view.css
View File

@@ -163,7 +163,7 @@
overflow: hidden; overflow: hidden;
} }
.clear_search_button { .old_clear_search_button {
grid-area: clear-search; grid-area: clear-search;
padding: 0; padding: 0;
} }

2
web/styles/right_sidebar.css
View File

@@ -481,7 +481,7 @@ $user_status_emoji_width: 24px;
white-space: nowrap; white-space: nowrap;
text-overflow: ellipsis; text-overflow: ellipsis;
overflow: hidden; overflow: hidden;
/* Prevent text from colliding with #clear_search_button */ /* Prevent text from colliding with #old_clear_search_button */
padding-right: 28px; padding-right: 28px;
height: var(--line-height-sidebar-row-prominent); height: var(--line-height-sidebar-row-prominent);
box-sizing: border-box; box-sizing: border-box;

2
web/styles/user_status.css
View File

@@ -23,7 +23,7 @@
} }
} }
.clear_search_button { .old_clear_search_button {
position: static; position: static;
padding: 6px; padding: 6px;
} }

2
web/templates/filter_topics.hbs
View File

@@ -1,6 +1,6 @@
<div class="topic_search_section filter-topics"> <div class="topic_search_section filter-topics">
<input class="topic-list-filter home-page-input filter_text_input" id="filter-topic-input" type="text" autocomplete="off" placeholder="{{t 'Filter topics'}}" /> <input class="topic-list-filter home-page-input filter_text_input" id="filter-topic-input" type="text" autocomplete="off" placeholder="{{t 'Filter topics'}}" />
<button type="button" class="bootstrap-btn clear_search_button" id="clear_search_topic_button"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear_search_topic_button">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

4
web/templates/left_sidebar.hbs
View File

@@ -165,7 +165,7 @@
</a> </a>
<div class="zoom-out-hide direct-messages-search-section"> <div class="zoom-out-hide direct-messages-search-section">
<input class="direct-messages-list-filter filter_text_input home-page-input" type="text" autocomplete="off" placeholder="{{t 'Filter direct messages' }}" /> <input class="direct-messages-list-filter filter_text_input home-page-input" type="text" autocomplete="off" placeholder="{{t 'Filter direct messages' }}" />
<button type="button" class="bootstrap-btn clear_search_button" id="clear-direct-messages-search-button"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear-direct-messages-search-button">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>
@@ -194,7 +194,7 @@
<div class="notdisplayed stream_search_section"> <div class="notdisplayed stream_search_section">
<input class="stream-list-filter home-page-input filter_text_input" type="text" autocomplete="off" placeholder="{{t 'Filter channels' }}" /> <input class="stream-list-filter home-page-input filter_text_input" type="text" autocomplete="off" placeholder="{{t 'Filter channels' }}" />
<button type="button" class="bootstrap-btn clear_search_button" id="clear_search_stream_button"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear_search_stream_button">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

2
web/templates/recent_view_table.hbs
View File

@@ -4,7 +4,7 @@
</div> </div>
<div class="search_group" role="group"> <div class="search_group" role="group">
<input type="text" id="recent_view_search" class="filter_text_input" value="{{ search_val }}" autocomplete="off" placeholder="{{t 'Filter topics (t)' }}" /> <input type="text" id="recent_view_search" class="filter_text_input" value="{{ search_val }}" autocomplete="off" placeholder="{{t 'Filter topics (t)' }}" />
<button type="button" class="bootstrap-btn clear_search_button" id="recent_view_search_clear"> <button type="button" class="bootstrap-btn old_clear_search_button" id="recent_view_search_clear">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

2
web/templates/set_status_overlay.hbs
View File

@@ -5,7 +5,7 @@
</div> </div>
</div> </div>
<input type="text" class="user-status modal_text_input" placeholder="{{t 'Your status' }}" maxlength="60"/> <input type="text" class="user-status modal_text_input" placeholder="{{t 'Your status' }}" maxlength="60"/>
<button type="button" class="bootstrap-btn clear_search_button" id="clear_status_message_button" disabled="disabled"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear_status_message_button" disabled="disabled">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

2
web/templates/stream_settings/stream_settings_overlay.hbs
View File

@@ -22,7 +22,7 @@
<div class="input-append stream_name_search_section" id="stream_filter"> <div class="input-append stream_name_search_section" id="stream_filter">
<input type="text" name="stream_name" id="search_stream_name" class="filter_text_input" autocomplete="off" <input type="text" name="stream_name" id="search_stream_name" class="filter_text_input" autocomplete="off"
placeholder="{{t 'Filter channels' }}" value=""/> placeholder="{{t 'Filter channels' }}" value=""/>
<button type="button" class="bootstrap-btn clear_search_button" id="clear_search_stream_name"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear_search_stream_name">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

2
web/templates/user_group_settings/user_group_settings_overlay.hbs
View File

@@ -22,7 +22,7 @@
<div class="input-append group_name_search_section" id="group_filter"> <div class="input-append group_name_search_section" id="group_filter">
<input type="text" name="group_name" id="search_group_name" class="filter_text_input" autocomplete="off" <input type="text" name="group_name" id="search_group_name" class="filter_text_input" autocomplete="off"
placeholder="{{t 'Filter groups' }}" value=""/> placeholder="{{t 'Filter groups' }}" value=""/>
<button type="button" class="bootstrap-btn clear_search_button" id="clear_search_group_name"> <button type="button" class="bootstrap-btn old_clear_search_button" id="clear_search_group_name">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>

2
web/templates/user_profile_modal.hbs
View File

@@ -119,7 +119,7 @@
</div> </div>
<div class="stream-search-container"> <div class="stream-search-container">
<input type="text" class="stream-search modal_text_input" placeholder="{{t 'Filter channels' }}" /> <input type="text" class="stream-search modal_text_input" placeholder="{{t 'Filter channels' }}" />
<button type="button" class="clear_search_button" id="clear_stream_search"> <button type="button" class="old_clear_search_button" id="clear_stream_search">
<i class="fa fa-remove" aria-hidden="true"></i> <i class="fa fa-remove" aria-hidden="true"></i>
</button> </button>
</div> </div>