mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	ldap: Use savepoint=True to avoid breaking ldap sync transaction.
Due to the atomic(savepoint=False) here, an LDAP sync exception while
syncing a single user breaks the whole sync_ldap_user_data transaction,
preventing it from successfully syncing other users.
Fixes a regression introduced in
1eecbad381
Closes #35291.
			
			
This commit is contained in:
		
				
					committed by
					
						
						Tim Abbott
					
				
			
			
				
	
			
			
			
						parent
						
							21558bd784
						
					
				
				
					commit
					4bd6fd6307
				
			@@ -491,6 +491,10 @@ python_rules = RuleList(
 | 
			
		||||
                    "zerver/tests/test_subs.py",
 | 
			
		||||
                    "with transaction.atomic(savepoint=True), self.assertRaises(JsonableError):",
 | 
			
		||||
                ),
 | 
			
		||||
                (
 | 
			
		||||
                    "zproject/backends.py",
 | 
			
		||||
                    "@transaction.atomic(savepoint=True)  # intentional use of savepoint=True",
 | 
			
		||||
                ),
 | 
			
		||||
            },
 | 
			
		||||
        },
 | 
			
		||||
        *whitespace_rules,
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user