paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_live_update: Fix double re-rendering of home_msg_list.

Browse Source 
The previous logic incorrectly did current_msg_list plus
home_msg_list, so if one wasn't narrowed, we did all the work twice.
This commit is contained in:
Tim Abbott
2018-04-02 18:26:50 -07:00
parent ee939f4c1a
commit 4bf6904dca
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
static/js/message_live_update.js
View File

@@ -3,13 +3,19 @@ var message_live_update = (function () {
var exports = {}; var exports = {};
exports.update_stream_name = function (stream_id, new_name) { exports.update_stream_name = function (stream_id, new_name) {
_.each([home_msg_list, current_msg_list, message_list.all], function (list) { _.each([home_msg_list, message_list.narrowed, message_list.all], function (list) {
if (list === undefined) {
return;
}
list.update_stream_name(stream_id, new_name); list.update_stream_name(stream_id, new_name);
}); });
}; };
exports.update_user_full_name = function (user_id, full_name) { exports.update_user_full_name = function (user_id, full_name) {
_.each([home_msg_list, current_msg_list, message_list.all], function (list) { _.each([home_msg_list, message_list.narrowed, message_list.all], function (list) {
if (list === undefined) {
return;
}
list.update_user_full_name(user_id, full_name); list.update_user_full_name(user_id, full_name);
}); });
}; };
@@ -18,7 +24,10 @@ exports.update_avatar = function (user_id, avatar_url) {
var url = avatar_url; var url = avatar_url;
url = people.format_small_avatar_url(url); url = people.format_small_avatar_url(url);
_.each([home_msg_list, current_msg_list, message_list.all], function (list) { _.each([home_msg_list, message_list.narrowed, message_list.all], function (list) {
if (list === undefined) {
return;
}
list.update_user_avatar(user_id, url); list.update_user_avatar(user_id, url);
}); });
}; };