refactor: Upstream calls to set_message_booleans.

We want to call `set_message_booleans` as soon as we
get data from the server, to avoid confusion about whether
`flags` is the authoritative field.

This commit has callers to `add_message_metadata` call
`set_message_booleans`.

This also sets us up to **not** call `set_message_booleans`
in the local echo codepath, where we can just have the
markdown processor set booleans natively.

frontend_tests/node_tests/message_store.js

@@ -84,6 +84,7 @@ global.people.initialize_current_user(me.user_id);
         is_me_message: false,
         id: 2067,
     };
+    message_store.set_message_booleans(message);
     message_store.add_message_metadata(message);
 
     assert.equal(message.is_private, true);
@@ -128,6 +129,7 @@ global.people.initialize_current_user(me.user_id);
         });
         global.with_stub(function (stub) {
             set_global('composebox_typeahead', {add_topic: stub.f});
+            message_store.set_message_booleans(message);
             message_store.add_message_metadata(message);
             var typeahead_added = stub.get_args('stream', 'subject');
             assert.deepEqual(typeahead_added.stream, [me, cindy]);

static/js/message_events.js

@@ -31,6 +31,7 @@ function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) {
                 }
             });
 
+            _.each(new_messages, message_store.set_message_booleans);
             new_messages = _.map(new_messages, message_store.add_message_metadata);
             message_util.add_messages(
                 new_messages,
@@ -54,6 +55,7 @@ function maybe_add_narrowed_messages(messages, msg_list, messages_are_new) {
 
 
 exports.insert_new_messages = function insert_new_messages(messages, locally_echoed) {
+    _.each(messages, message_store.set_message_booleans);
     messages = _.map(messages, message_store.add_message_metadata);
 
     unread.process_loaded_messages(messages);

static/js/message_fetch.js

@@ -23,6 +23,7 @@ function process_result(messages, opts) {
         narrow.show_empty_narrow_message();
     }
 
+    _.each(messages, message_store.set_message_booleans);
     messages = _.map(messages, message_store.add_message_metadata);
 
     // If we're loading more messages into the home view, save them to

static/js/message_store.js

@@ -121,8 +121,6 @@ exports.add_message_metadata = function (message) {
 
     message.sent_by_me = people.is_current_user(message.sender_email);
 
-    exports.set_message_booleans(message);
-
     people.extract_people_from_message(message);
     people.maybe_incr_recipient_count(message);