paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

right_sidebar: Rename to right column wherever applicable.

Browse Source 
In our css variables, we were using sidebar and column interchangably.
But, sidebar is 10px less wider than the column. This commit makes no
behaviour change, but renames variables to use column where necessary
and uses variable for sidebar instead of a fixed 240px value.
This commit is contained in:
Shubham Padia
2024-12-10 11:33:59 +00:00
committed by Tim Abbott
parent dc326dd5ed
commit 4da8cf35bf
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/styles/app_variables.css
View File

@@ -262,7 +262,8 @@
--left-sidebar-width: min(33.3333%, var(--left-sidebar-max-width));
/* 40px (toggle icon) + 5px (gap) + 20px logo + 10px right margin */
--left-sidebar-width-with-realm-icon-logo: 75px;
--right-sidebar-width: 250px;
--right-column-width: 250px;
--right-sidebar-width: calc(var(--right-column-width) - 10px);
/* The width of the icon is reduced by 2px, to account for 2px
of top and bottom margin needed for hover backgrounds to
not touch the row outline. */

8
web/styles/zulip.css
View File

@@ -337,8 +337,8 @@ body.has-overlay-scrollbar {
/* This applies to column-left both in navbar and app. */
.column-right {
width: var(--right-sidebar-width);
max-width: var(--right-sidebar-width);
width: var(--right-column-width);
max-width: var(--right-column-width);
position: absolute;
right: 0;
top: 0;
@@ -502,7 +502,7 @@ body.has-overlay-scrollbar {
.column-right .right-sidebar {
padding-left: 5px;
width: 240px;
width: var(--right-sidebar-width);
}
.column-middle {
@@ -513,7 +513,7 @@ body.has-overlay-scrollbar {
.column-middle,
#compose-content {
margin-right: var(--right-sidebar-width);
margin-right: var(--right-column-width);
margin-left: calc(
var(--left-sidebar-width) + var(--left-sidebar-padding-left)
);