paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use update_fields more consistently when modifying model objects.

Browse Source 
(imported from commit a3f0c308b621b5ff85c55654f187e25749192b19)
This commit is contained in:
Tim Abbott
2013-07-23 16:01:38 -04:00
parent f800e6cebb
commit 4e1434b28d
8 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zephyr/lib/actions.py
View File

@@ -936,7 +936,7 @@ def subscribed_to_stream(user_profile, stream):
def do_update_onboarding_steps(user_profile, steps):
user_profile.onboarding_steps = ujson.dumps(steps)
user_profile.save()
user_profile.save(update_fields=["onboarding_steps"])
log_event({'type': 'update_onboarding',
'user': user_profile.email,

2
zephyr/management/commands/bankrupt_users.py
View File

@@ -30,7 +30,7 @@ Usage: python manage.py bankrupt_users <list of email addresses>"""
old_pointer = user_profile.pointer
new_pointer = messages[0].id
user_profile.pointer = new_pointer
user_profile.save()
user_profile.save(update_fields=["pointer"])
print "%s: %d => %d" % (email, old_pointer, new_pointer)
else:
print "%s has no messages, can't bankrupt!" % (email,)

2
zephyr/management/commands/delete_tutorial_streams.py
View File

@@ -45,7 +45,7 @@ class Command(BaseCommand):
if options["for_real"]:
tutorial_user = subscribers[0]
tutorial_user.active = False
tutorial_user.save()
tutorial_user.save(update_fields=["active"])
if options["for_real"]:
print "Subscriptions deactivated."

2
zephyr/management/commands/dump_pointers.py
View File

@@ -36,7 +36,7 @@ def restore(change):
continue
if change:
u.pointer = pointer
u.save()
u.save(update_fields=["pointer"])
class Command(BaseCommand):
option_list = BaseCommand.option_list + (

11
zephyr/management/commands/populate_db.py
View File

@@ -558,21 +558,22 @@ def restore_saved_messages():
# Just handle these the slow way
user_profile = users[old_message["user"]]
user_profile.full_name = old_message["full_name"]
user_profile.save()
user_profile.save(update_fields=["full_name"])
continue
elif message_type == "enable_desktop_notifications_changed":
# Just handle these the slow way
user_profile = users[old_message["user"]]
user_profile.enable_desktop_notifications = (old_message["enable_desktop_notifications"] != "false")
user_profile.save()
user_profile.save(update_fields=["enable_desktop_notifications"])
continue
elif message_type == "enable_sounds_changed":
user_profile = users[old_message["user"]]
user_profile.enable_sounds = (old_message["enable_sounds"] != "false")
user_profile.save(update_fields=["enable_sounds"])
elif message_type == "enable_offline_email_notifications_changed":
user_profile = users[old_message["user"]]
user_profile.enable_offline_email_notifications = (old_message["enable_offline_email_notifications"] != "false")
user_profile.save()
user_profile.save(update_fields=["enable_offline_email_notifications"])
continue
elif message_type == "default_streams":
set_default_streams(Realm.objects.get(domain=old_message["domain"]),
@@ -656,7 +657,7 @@ def restore_saved_messages():
with transaction.commit_on_success():
for (sub, active) in subscriptions_to_change:
current_subs_obj[sub].active = active
current_subs_obj[sub].save()
current_subs_obj[sub].save(update_fields=["active"])
subs = {}
for sub in Subscription.objects.all():
@@ -683,7 +684,7 @@ def restore_saved_messages():
user_profile.pointer = top.message_id
except IndexError:
user_profile.pointer = -1
user_profile.save()
user_profile.save(update_fields=["pointer"])
print datetime.datetime.now(), "Done replaying old messages"

2
zephyr/management/commands/sync_api_key.py
View File

@@ -20,4 +20,4 @@ class Command(BaseCommand):
user_profile = get_user_profile_by_email(email)
user_profile.api_key = api_key
user_profile.save()
user_profile.save(update_fields=["api_key"])

2
zephyr/management/commands/update_mit_fullnames.py
View File

@@ -19,7 +19,7 @@ def update_mit_fullnames(change=False):
print "%s: %s => %s" % (u.email, u.full_name, computed_name)
if change:
u.full_name = computed_name
u.save()
u.save(update_fields=["full_name"])
class Command(BaseCommand):
option_list = BaseCommand.option_list + (

10
zephyr/views.py
View File

@@ -413,8 +413,7 @@ def handle_openid_errors(request, issue, openid_response=None):
if form.is_valid():
# Construct a PreregistrationUser object and send the user over to
# the confirmation view.
prereg_user = PreregistrationUser()
prereg_user.email = google_email
prereg_user = PreregistrationUser(email=google_email)
prereg_user.save()
return redirect("".join((
"/",
@@ -475,8 +474,7 @@ def accounts_home(request):
form = HomepageForm(request.POST)
if form.is_valid():
email = form.cleaned_data['email']
prereg_user = PreregistrationUser()
prereg_user.email = email
prereg_user = PreregistrationUser(email=email)
prereg_user.save()
Confirmation.objects.send_confirmation(prereg_user, email)
return HttpResponseRedirect(reverse('send_confirm', kwargs={'email': email}))
@@ -508,7 +506,7 @@ def home(request):
# user has since logged in
if not user_profile.last_reminder is None:
user_profile.last_reminder = None
user_profile.save()
user_profile.save(update_fields=["last_reminder"])
# Brand new users get the tutorial
needs_tutorial = settings.TUTORIAL_ENABLED and \
@@ -1052,7 +1050,7 @@ def json_tutorial_status(request, user_profile, status=REQ('status')):
user_profile.tutorial_status = UserProfile.TUTORIAL_STARTED
elif status == 'finished':
user_profile.tutorial_status = UserProfile.TUTORIAL_FINISHED
user_profile.save()
user_profile.save(update_fields=["tutorial_status"])
return json_success()