paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 12:33:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Remove compatibility code for Python < 3.5.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2023-07-21 16:37:06 -07:00
committed by Tim Abbott
parent bca5564c1e
commit 4e645c8ff9
2 changed files with 21 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/tests/test_zulint_custom_rules.py
View File

@@ -48,25 +48,15 @@ class TestRuleList(TestCase):
for rule in self.all_rules:
pattern = rule["pattern"]
for line in rule.get("good_lines", []):
# create=True is superfluous when mocking built-ins in Python >= 3.5
with patch(
"builtins.open",
return_value=StringIO(line + "\n\n"),
create=True,
autospec=True,
):
with patch("builtins.open", return_value=StringIO(line + "\n\n"), autospec=True):
self.assertFalse(
RuleList([], [rule]).custom_check_file("foo.bar", "baz", ""),
f"The pattern '{pattern}' matched the line '{line}' while it shouldn't.",
)
for line in rule.get("bad_lines", []):
# create=True is superfluous when mocking built-ins in Python >= 3.5
with patch(
"builtins.open",
return_value=StringIO(line + "\n\n"),
create=True,
autospec=True,
"builtins.open", return_value=StringIO(line + "\n\n"), autospec=True
), patch("builtins.print"):
filename = list(rule.get("include_only", {"foo.bar"}))[0]
self.assertTrue(