paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

upload: Support drag and dropping files anywhere on message viewport.

Browse Source 
While Zulip has supported drag/drop into the compose box for some
time, if you drag/drop the file onto other parts of the message
viewport, it would just do the default browswer behavior of replacing
the Zulip app with that file opened in a new tab, which nobody wants.

The inline comments document the set of rules for how we choose
whether to drop the upload into the compose box or an edit widget, and
also how to open the compose box in different situations.

Fixes #14579.
This commit is contained in:
Brijmohan Siyag
2023-06-16 16:19:02 +05:30
committed by Tim Abbott
parent 1b9fb037a1
commit 4e7bf3c4fb
5 changed files with 251 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/message_edit.js
View File

@@ -742,6 +742,10 @@ export function end_inline_topic_edit($row) {
message_lists.current.hide_edit_topic_on_recipient_row($row);
}
export function get_upload_object_from_row(row_id) {
return upload_objects_by_row.get(row_id);
}
function remove_uploads_from_row(row_id) {
const uploads_for_row = upload_objects_by_row.get(row_id);
// We need to cancel all uploads, reset their progress,