paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark messages taller than the screen as read once we have moved past them

Browse Source 
(imported from commit c142c2447a8f2b5ed40337a75c1afbaf05f9fecf)
This commit is contained in:
Leo Franchi
2013-03-20 16:20:31 -04:00
parent a95b1a1a23
commit 4edf85e730
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zephyr/static/js/zephyr.js
View File

@@ -324,19 +324,29 @@ function process_visible_unread_messages() {
} }
var selected = current_msg_list.selected_message(); var selected = current_msg_list.selected_message();
var bottom = viewport.scrollTop() + viewport.height(); var top = viewport.scrollTop();
var middle = viewport.scrollTop() + (viewport.height() / 2); var height = viewport.height();
var bottom = top + height;
var middle = top + (height / 2);
// Being simplistic about this, the smallest message is 30 px high. // Being simplistic about this, the smallest message is 30 px high.
var selected_row = rows.get(current_msg_list.selected_id(), current_msg_list.table_name); var selected_row = rows.get(current_msg_list.selected_id(), current_msg_list.table_name);
var num_neighbors = Math.floor(viewport.height() / 30); var num_neighbors = Math.floor(height / 30);
var candidates = $.merge(selected_row.prevAll("tr.message_row[zid]:lt(" + num_neighbors + ")"), var candidates = $.merge(selected_row.prevAll("tr.message_row[zid]:lt(" + num_neighbors + ")"),
selected_row.nextAll("tr.message_row[zid]:lt(" + num_neighbors + ")")); selected_row.nextAll("tr.message_row[zid]:lt(" + num_neighbors + ")"));
var visible_messages = candidates.filter(function (idx, message) { var visible_messages = candidates.filter(function (idx, message) {
var row = $(message); var row = $(message);
var row_bottom = (row.offset().top + row.height()); var row_top = row.offset().top;
var entirely_within_view = row.offset().top > viewport.scrollTop() && row_bottom < bottom; var row_height = row.height();
var row_bottom = (row_top + row_height);
var entirely_within_view = row_top > top && row_bottom < bottom;
// Mark very tall messages as read once we've gotten past them
if (row_height > height && row_top > top) {
return true;
}
return entirely_within_view; return entirely_within_view;
}); });