mirror of
https://github.com/zulip/zulip.git
synced 2025-11-10 08:56:10 +00:00
settings: Disable django.request logging at WARNING log level.
The comment explains this issue, but effectively, the upgrade to Django 2.x means that Django's built-in django.request logger was writing to our errors logs WARNING-level data for every 404 and 400 error. We don't consider user errors to be a problem worth highlighting in that log file.
This commit is contained in:
@@ -5,7 +5,6 @@ from django.utils.timezone import utc as timezone_utc
|
||||
|
||||
import hashlib
|
||||
import logging
|
||||
import re
|
||||
import threading
|
||||
import traceback
|
||||
from typing import Optional, Tuple
|
||||
@@ -125,38 +124,6 @@ def skip_200_and_304(record: logging.LogRecord) -> bool:
|
||||
|
||||
return True
|
||||
|
||||
IGNORABLE_404_URLS = [
|
||||
re.compile(r'^/apple-touch-icon.*\.png$'),
|
||||
re.compile(r'^/favicon\.ico$'),
|
||||
re.compile(r'^/robots\.txt$'),
|
||||
re.compile(r'^/django_static_404.html$'),
|
||||
re.compile(r'^/wp-login.php$'),
|
||||
]
|
||||
|
||||
def skip_boring_404s(record: logging.LogRecord) -> bool:
|
||||
"""Prevents Django's 'Not Found' warnings from being logged for common
|
||||
404 errors that don't reflect a problem in Zulip. The overall
|
||||
result is to keep the Zulip error logs cleaner than they would
|
||||
otherwise be.
|
||||
|
||||
Assumes that its input is a django.request log record.
|
||||
"""
|
||||
# Apparently, `status_code` is added by Django and is not an actual
|
||||
# attribute of LogRecord; as a result, mypy throws an error if we
|
||||
# access the `status_code` attribute directly.
|
||||
if getattr(record, 'status_code') != 404:
|
||||
return True
|
||||
|
||||
# We're only interested in filtering the "Not Found" errors.
|
||||
if getattr(record, 'msg') != 'Not Found: %s':
|
||||
return True
|
||||
|
||||
path = getattr(record, 'args', [''])[0]
|
||||
for pattern in IGNORABLE_404_URLS:
|
||||
if re.match(pattern, path):
|
||||
return False
|
||||
return True
|
||||
|
||||
def skip_site_packages_logs(record: logging.LogRecord) -> bool:
|
||||
# This skips the log records that are generated from libraries
|
||||
# installed in site packages.
|
||||
|
||||
Reference in New Issue
Block a user