diff --git a/static/templates/emoji_popover_content.hbs b/static/templates/emoji_popover_content.hbs index 8a751297ca..6d3efe4b19 100644 --- a/static/templates/emoji_popover_content.hbs +++ b/static/templates/emoji_popover_content.hbs @@ -1,6 +1,6 @@
- +
diff --git a/static/templates/emoji_popover_emoji.hbs b/static/templates/emoji_popover_emoji.hbs index 199e7f8cfd..3d660da870 100644 --- a/static/templates/emoji_popover_emoji.hbs +++ b/static/templates/emoji_popover_emoji.hbs @@ -1,5 +1,5 @@ {{#with emoji_dict}} -
+
{{#if is_realm_emoji}} {{else}} diff --git a/static/templates/input_pill.hbs b/static/templates/input_pill.hbs index 72068067d7..1e1a249ca2 100644 --- a/static/templates/input_pill.hbs +++ b/static/templates/input_pill.hbs @@ -1,6 +1,6 @@
{{#if has_image}} - + {{/if}} {{ display_value }}
diff --git a/static/templates/message_reaction.hbs b/static/templates/message_reaction.hbs index 6fadb7d92b..56776d67f1 100644 --- a/static/templates/message_reaction.hbs +++ b/static/templates/message_reaction.hbs @@ -1,4 +1,4 @@ -
+
{{#if this.emoji_alt_code}}
 :{{this.emoji_name}}:
{{else}} diff --git a/static/templates/muted_topic_ui_row.hbs b/static/templates/muted_topic_ui_row.hbs index 7a5f09aa08..574b1c6cb3 100644 --- a/static/templates/muted_topic_ui_row.hbs +++ b/static/templates/muted_topic_ui_row.hbs @@ -1,5 +1,5 @@ {{#with muted_topics}} - + {{stream}} {{topic}} {{date_muted_str}} diff --git a/static/templates/settings/notification_settings.hbs b/static/templates/settings/notification_settings.hbs index 0eb2ab3281..d6ae9b5a95 100644 --- a/static/templates/settings/notification_settings.hbs +++ b/static/templates/settings/notification_settings.hbs @@ -76,7 +76,7 @@ {{/each}} - +
diff --git a/static/templates/user_profile_modal.hbs b/static/templates/user_profile_modal.hbs index a72038b6bb..210f47dcfd 100644 --- a/static/templates/user_profile_modal.hbs +++ b/static/templates/user_profile_modal.hbs @@ -50,9 +50,9 @@
{{else if this.is_link}} - {{this.value}} + {{this.value}} {{else if this.is_external_account}} - {{this.value}} + {{this.value}} {{else}} {{#if this.rendered_value}}
{{rendered_markdown this.rendered_value}}
diff --git a/templates/zerver/archive/single_message.html b/templates/zerver/archive/single_message.html index bdde03a2ca..705d5935a1 100644 --- a/templates/zerver/archive/single_message.html +++ b/templates/zerver/archive/single_message.html @@ -5,7 +5,7 @@ {% if include_sender %}
- +
{% if status_message %} diff --git a/templates/zerver/integrations/index.html b/templates/zerver/integrations/index.html index f22b58ab1d..dd646c7f4c 100644 --- a/templates/zerver/integrations/index.html +++ b/templates/zerver/integrations/index.html @@ -144,7 +144,7 @@ {% for integration in integrations_dict.values() %} {% if integration.is_enabled() %} -
+

Logos are trademarks of their respective owners. diff --git a/templates/zerver/register.html b/templates/zerver/register.html index 7840bb20ae..6c26010000 100644 --- a/templates/zerver/register.html +++ b/templates/zerver/register.html @@ -28,7 +28,7 @@ Form is validated both client-side using jquery-validate (see signup.js) and ser + name="realm_name" maxlength="{{ MAX_REALM_NAME_LENGTH }}" required />

{% if form.realm_name.errors %} @@ -63,7 +63,7 @@ Form is validated both client-side using jquery-validate (see signup.js) and ser class="{% if root_domain_landing_page %}required{% endif %} subdomain" type="text" placeholder="acme" value="{% if form.realm_subdomain.value() %}{{ form.realm_subdomain.value() }}{% endif %}" - name="realm_subdomain" maxlength={{ MAX_REALM_SUBDOMAIN_LENGTH }} + name="realm_subdomain" maxlength="{{ MAX_REALM_SUBDOMAIN_LENGTH }}" {% if root_domain_landing_page %}required{% endif %} />

@@ -124,7 +124,7 @@ Form is validated both client-side using jquery-validate (see signup.js) and ser {% else %} + maxlength="{{ MAX_NAME_LENGTH }}" placeholder="{% trans %}Full name or 名前{% endtrans %}" required /> {% if form.full_name.errors %} {% for error in form.full_name.errors %} @@ -151,7 +151,7 @@ Form is validated both client-side using jquery-validate (see signup.js) and ser
diff --git a/tools/linter_lib/custom_check.py b/tools/linter_lib/custom_check.py index 59e7896d78..69a64db2bd 100644 --- a/tools/linter_lib/custom_check.py +++ b/tools/linter_lib/custom_check.py @@ -498,6 +498,12 @@ html_rules: List["Rule"] = whitespace_rules + prose_style_rules + [ 'exclude': {"templates/analytics/support.html"}, 'good_lines': [''], 'bad_lines': ['']}, + {'pattern': '={', + # TODO: Improve the Apple auth patterns so we can remove this. + 'exclude_pattern': 'appleid.cdn-apple.com/appleid/button', + 'description': "Likely missing quoting in HTML attribute", + 'good_lines': [''], + 'bad_lines': ['']}, {'pattern': "placeholder='[^{]", 'description': "`placeholder` value should be translatable.", 'good_lines': [''],