From 50d65fffe68d277be5bb359ec2e240d5cf64055d Mon Sep 17 00:00:00 2001
From: sahil839 <sahilbatra839@gmail.com>
Date: Wed, 1 Apr 2020 12:00:41 +0530
Subject: [PATCH] tests: Change policy elements value to correct type in
 page_params.

Fields like realm_email_address_visibility and realm_bot_creation_policy
were strings instead of integers in page_params obeject in
settings_org.js tests.

Also use values struct defined in settings_config.js and setting_bots.js
instead of direct values for improving readability.
---
 frontend_tests/node_tests/settings_org.js | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/frontend_tests/node_tests/settings_org.js b/frontend_tests/node_tests/settings_org.js
index 4cec5cf3c1..2f03a4f0d2 100644
--- a/frontend_tests/node_tests/settings_org.js
+++ b/frontend_tests/node_tests/settings_org.js
@@ -69,6 +69,7 @@ set_global('realm_logo', _realm_logo);
 set_global('ui_report', _ui_report);
 
 const settings_config = zrequire('settings_config');
+const settings_bots = zrequire('settings_bots');
 zrequire('stream_data');
 zrequire('settings_account');
 zrequire('settings_org');
@@ -190,15 +191,17 @@ function createSaveButtons(subsection) {
 
 function test_submit_settings_form(submit_form) {
     Object.assign(page_params, {
-        realm_bot_creation_policy: '2',
-        realm_email_address_visibility: '2',
+        realm_bot_creation_policy: settings_bots.bot_creation_policy_values.restricted.code,
+        realm_email_address_visibility:
+                settings_config.email_address_visibility_values.admins_only.code,
         realm_add_emoji_by_admins_only: true,
         realm_create_stream_by_admins_only: true,
         realm_waiting_period_threshold: 1,
         realm_default_language: '"es"',
-        realm_default_twenty_four_hour_time: 'false',
-        realm_invite_to_stream_policy: 2,
-        realm_create_stream_policy: 1,
+        realm_default_twenty_four_hour_time: false,
+        realm_invite_to_stream_policy:
+                settings_config.invite_to_stream_policy_values.by_admins_only.code,
+        realm_create_stream_policy: settings_config.create_stream_policy_values.by_members.code,
     });
 
     global.patch_builtin('setTimeout', func => func());