paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

decorator: Fix is_browser_view handling of e.g. mobile apps.

Browse Source 
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
This commit is contained in:
Tim Abbott
2017-08-24 16:21:05 -07:00
parent 7ffc107061
commit 5206dad373
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
zerver/decorator.py
View File

@@ -145,11 +145,10 @@ def get_client_name(request, is_browser_view):
if user_agent is not None:
# We could check for a browser's name being "Mozilla", but
# e.g. Opera and MobileSafari don't set that, and it seems
# more robust to just key off whether it was a json view
if is_browser_view and user_agent["name"] not in {"ZulipDesktop", "ZulipElectron"}:
# Avoid changing the client string for browsers Once this
# is out to prod, we can name the field to something like
# Browser for consistency.
# more robust to just key off whether it was a browser view
if is_browser_view and not user_agent["name"].startswith("Zulip"):
# Avoid changing the client string for browsers, but let
# the Zulip desktop and mobile apps be themselves.
return "website"
else:
return user_agent["name"]