paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji refactor: Let emoji.js own the data.

Browse Source 
We now only use page_params.realm_emoji at
intialization time, and then settings_emoji
gets the data from emoji.js.
This commit is contained in:
Steve Howell
2020-07-23 22:39:22 +00:00
committed by Anders Kaseorg
parent d11c6686a1
commit 5280b87f19
4 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/emoji.js
View File

@@ -11,6 +11,16 @@ exports.all_realm_emojis = new Map();
exports.active_realm_emojis = new Map();
exports.default_emoji_aliases = new Map();
// For legacy reasons we track server_realm_emoji_data,
// since our settings code builds off that format. We
// should move it to use all_realm_emojis, which requires
// adding author_id here and then changing the settings code
// in a slightly non-trivial way.
exports.server_realm_emoji_data = {};
// We really want to deprecate this, too.
exports.get_server_realm_emoji_data = () => exports.server_realm_emoji_data;
const emoticon_translations = (() => {
/*
@@ -91,6 +101,10 @@ exports.get_realm_emoji_url = (emoji_name) => {
};
exports.update_emojis = function (realm_emojis) {
// The settings code still works with the
// server format of the data.
exports.server_realm_emoji_data = realm_emojis;
// exports.all_realm_emojis is emptied before adding the realm-specific emoji
// to it. This makes sure that in case of deletion, the deleted realm_emojis
// don't persist in exports.active_realm_emojis.