puppet: Ensure that all scripts/lib/install packages are installed.

These have all been required packages for some time, but this helps
keep the install-time list more clearly a subset of the upgrade-time
list.

puppet/zulip/manifests/profile/base.pp

@@ -33,13 +33,18 @@ class zulip::profile::base {
         '20.04' => 'focal',
       }
       $base_packages = [
-        # Accurate time is essential
+        # Basics
-        'ntp',
+        'python3',
+        'puppet',
+        'git',
         # Used in scripts including install-yarn.sh
         'curl',
         'wget',
+        'jq',
         # Used to read /etc/zulip/zulip.conf for `zulipconf` Puppet function
         'crudini',
+        # Accurate time is essential
+        'ntp',
         # Used for tools like sponge
         'moreutils',
         # Nagios monitoring plugins
@@ -53,10 +58,14 @@ class zulip::profile::base {
     'redhat': {
       $release_name = "${::operatingsystem}${::operatingsystemmajrelease}"
       $base_packages = [
-        'ntp',
+        'python3',
+        'puppet',
+        'git',
         'curl',
         'wget',
+        'jq',
         'crudini',
+        'ntp',
         'moreutils',
         'nmap-ncat',
         'nagios-plugins',  # there is no dummy package on CentOS 7

scripts/lib/install

@@ -323,9 +323,11 @@ if [ -z "$NO_DIST_UPGRADE" ]; then
 fi
 
 if [ "$package_system" = apt ]; then
+    # Note that any additions to these lists must also be added to
+    # `zulip::profile::base` such that the new dependency is seen by
+    # upgrades, as well as new installs.
     if ! apt-get install -y \
-        puppet git curl wget jq \
+        python3 puppet git curl wget jq crudini \
-        python3 crudini \
         "${ADDITIONAL_PACKAGES[@]}"; then
         set +x
         echo -e '\033[0;31m' >&2
@@ -336,8 +338,7 @@ if [ "$package_system" = apt ]; then
     fi
 elif [ "$package_system" = yum ]; then
     if ! yum install -y \
-        puppet git curl wget jq \
+        python3 puppet git curl wget jq crudini \
-        python3 crudini \
         "${ADDITIONAL_PACKAGES[@]}"; then
         set +x
         echo -e '\033[0;31m' >&2