paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 06:28:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

EmailAuthBackend: Convert a return to assert for a now-impossible case.

Browse Source
This commit is contained in:
Tim Abbott
2017-11-21 12:32:42 -08:00
parent 1b95b098dd
commit 53224a16a9
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zproject/backends.py
View File

@@ -339,10 +339,10 @@ class EmailAuthBackend(ZulipAuthMixin):
return_data: Optional[Dict[str, Any]]=None) -> Optional[UserProfile]: return_data: Optional[Dict[str, Any]]=None) -> Optional[UserProfile]:
""" Authenticate a user based on email address as the user name. """ """ Authenticate a user based on email address as the user name. """
if username is None or password is None: if username is None or password is None:
# Return immediately. Otherwise we will look for a SQL row with # Because of how we structure our auth calls to always
# NULL username. While that's probably harmless, it's needless # specify which backend to use when not using
# exposure. # EmailAuthBackend, username and password should always be set.
return None raise AssertionError("Invalid call to authenticate for EmailAuthBackend")
user_profile = common_get_active_user_by_email(username, return_data=return_data) user_profile = common_get_active_user_by_email(username, return_data=return_data)
if user_profile is None: if user_profile is None: