paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

messages: Modify access_message for is_history_public_to_subscribers.

Browse Source 
This completes the Message side of #2745.
This commit is contained in:
Tim Abbott
2018-04-04 16:12:30 -07:00
parent bec71d7a50
commit 53e47e6991
2 changed files with 31 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/tests/test_messages.py
View File

@@ -2262,6 +2262,7 @@ class MirroredMessageUsersTest(ZulipTestCase):
self.assertTrue(bob.is_mirror_dummy)
class StarTests(ZulipTestCase):
"""This is also the main test for access_message"""
def change_star(self, messages: List[int], add: bool=True, **kwargs: Any) -> HttpResponse:
return self.client_post("/json/messages/flags",
@@ -2405,6 +2406,18 @@ class StarTests(ZulipTestCase):
result = self.change_star(message_ids)
self.assert_json_error(result, 'Invalid message(s)')
with self.settings(PRIVATE_STREAM_HISTORY_FOR_SUBSCRIBERS=True):
# With PRIVATE_STREAM_HISTORY_FOR_SUBSCRIBERS, you still
# can't see it if you didn't receive the message and are
# not subscribed.
result = self.change_star(message_ids)
self.assert_json_error(result, 'Invalid message(s)')
# But if you subscribe, then you can star the message
self.subscribe(self.example_user("cordelia"), stream_name)
result = self.change_star(message_ids)
self.assert_json_success(result)
def test_new_message(self) -> None:
"""
New messages aren't starred.