paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Add a lint check for bare type: ignores.

Browse Source
This commit is contained in:
Tim Abbott
2017-07-27 15:59:36 -07:00
parent e6e3bbb780
commit 53e4d8562b
6 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/setup/generate_secrets.py
View File

@@ -61,7 +61,7 @@ def get_old_conf(output_filename):
secrets_file = six.moves.configparser.RawConfigParser() secrets_file = six.moves.configparser.RawConfigParser()
secrets_file.read(output_filename) secrets_file.read(output_filename)
return dict(secrets_file.items("secrets")) # type: ignore return dict(secrets_file.items("secrets")) # type: ignore # likely typeshed issue
def generate_secrets(development=False): def generate_secrets(development=False):
# type: (bool) -> None # type: (bool) -> None

5
tools/linter_lib/custom_check.py
View File

@@ -205,6 +205,11 @@ def build_custom_checkers(by_lang):
'description': 'Use `is None` to check whether something is None'}, 'description': 'Use `is None` to check whether something is None'},
{'pattern': "type:[(]", {'pattern': "type:[(]",
'description': 'Missing whitespace after ":" in type annotation'}, 'description': 'Missing whitespace after ":" in type annotation'},
{'pattern': "type: ignore$",
'exclude': set(['tools/tests',
'zerver/lib/test_runner.py',
'zerver/tests']),
'description': '"type: ignore" should always end with "# type: ignore # explanation for why"'},
{'pattern': "# type [(]", {'pattern': "# type [(]",
'description': 'Missing : after type in type annotation'}, 'description': 'Missing : after type in type annotation'},
{'pattern': "#type", {'pattern': "#type",

2
zerver/lib/bot_lib.py
View File

@@ -76,5 +76,5 @@ class EmbeddedBotHandler(object):
our_dir, '..', 'bots', bot_name, bot_name + '.conf')) our_dir, '..', 'bots', bot_name, bot_name + '.conf'))
section = section or bot_name section = section or bot_name
config = configparser.ConfigParser() config = configparser.ConfigParser()
config.readfp(open(conf_file_path)) # type: ignore config.readfp(open(conf_file_path)) # type: ignore # likely typeshed issue
return dict(config.items(section)) return dict(config.items(section))

2
zerver/lib/test_helpers.py
View File

@@ -171,7 +171,7 @@ def stdout_suppressed():
"""Redirect stdout to /dev/null.""" """Redirect stdout to /dev/null."""
with open(os.devnull, 'a') as devnull: with open(os.devnull, 'a') as devnull:
stdout, sys.stdout = sys.stdout, devnull # type: ignore stdout, sys.stdout = sys.stdout, devnull # type: ignore # monkey-patching
yield stdout yield stdout
sys.stdout = stdout sys.stdout = stdout

2
zerver/migrations/0077_add_file_name_field_to_realm_emoji.py
View File

@@ -97,7 +97,7 @@ class LocalUploader(Uploader):
def write_local_file(self, path, file_data): def write_local_file(self, path, file_data):
# type: (Text, binary_type) -> None # type: (Text, binary_type) -> None
self.mkdirs(path) self.mkdirs(path)
with open(path, 'wb') as f: # type: ignore with open(path, 'wb') as f: # type: ignore # likely mypy bug
f.write(file_data) f.write(file_data)
def upload_files(self, response, resized_image, dst_path_id): def upload_files(self, response, resized_image, dst_path_id):

2
zproject/backends.py
View File

@@ -244,7 +244,7 @@ class SocialAuthMixin(ZulipAuthMixin):
""" """
try: try:
# Call the auth_complete method of BaseOAuth2 is Python Social Auth # Call the auth_complete method of BaseOAuth2 is Python Social Auth
return super(SocialAuthMixin, self).auth_complete(*args, **kwargs) # type: ignore return super(SocialAuthMixin, self).auth_complete(*args, **kwargs) # type: ignore # monkey-patching
except AuthFailed: except AuthFailed:
return None return None
except SocialAuthBaseException as e: except SocialAuthBaseException as e: