From 540904aa9d9918bcaf62858c89d9257021ea4db1 Mon Sep 17 00:00:00 2001 From: sahil839 Date: Thu, 20 May 2021 00:26:53 +0530 Subject: [PATCH] giphy: Add a '?' icon besides the "GIPHY integration" label. We add a '?' icon besides the "GIPHY integration" label of giphy settings dropdown. The icon links to readthedocs page for setting up giphy API key when api key is not set, and it points to help center article of GIFs when the api key is added. --- static/js/admin.js | 6 ++++++ static/templates/settings/organization_settings_admin.hbs | 1 + 2 files changed, 7 insertions(+) diff --git a/static/js/admin.js b/static/js/admin.js index a8cd16e400..05c8010c4c 100644 --- a/static/js/admin.js +++ b/static/js/admin.js @@ -135,6 +135,12 @@ export function build_page() { options.realm_night_logo_url = options.realm_logo_url; } + options.giphy_help_link = "/help/animated-gifs-from-giphy"; + if (options.giphy_api_key_empty) { + options.giphy_help_link = + "https://zulip.readthedocs.io/en/latest/production/giphy-gif-integration.html"; + } + const rendered_admin_tab = render_admin_tab(options); $("#settings_content .organization-box").html(rendered_admin_tab); $("#settings_content .alert").removeClass("show"); diff --git a/static/templates/settings/organization_settings_admin.hbs b/static/templates/settings/organization_settings_admin.hbs index 81238712a2..b0ae6a6f92 100644 --- a/static/templates/settings/organization_settings_admin.hbs +++ b/static/templates/settings/organization_settings_admin.hbs @@ -197,6 +197,7 @@