paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit: Replace checkboxes with settings_checkbox partial.

Browse Source 
This commits replaces the custom `send_notification` message_edit
checkboxes with our `settings_checkbox` partial.

The main intention is to also support the feature of selecting a
checkbox by clicking over its corresponding label as we have
in the case of the organization settings checkboxes.

Due to above change, this commit also removes the redundant
`break-row` HTML class along with it styles.
This commit is contained in:
aryanshridhar
2021-07-21 13:41:25 +00:00
committed by Tim Abbott
parent a8887948cb
commit 54a1c73c78
4 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/message_edit.js
View File

@@ -832,10 +832,10 @@ export function save_message_row_edit(row) {
const selected_topic_propagation =
row.find("select.message_edit_topic_propagate").val() || "change_later";
const send_notification_to_old_thread = row
.find(".send_notification_to_old_thread")
.find("#id_send_notification_to_old_thread")
.is(":checked");
const send_notification_to_new_thread = row
.find(".send_notification_to_new_thread")
.find("#id_send_notification_to_new_thread")
.is(":checked");
request.propagate_mode = selected_topic_propagation;
request.send_notification_to_old_thread = send_notification_to_old_thread;