From 54dd7f0a432891a300f1171e3ccbf178cf98cee0 Mon Sep 17 00:00:00 2001 From: Yashashvi Dave Date: Sat, 3 Nov 2018 00:15:32 +0530 Subject: [PATCH] user info popover: Add user type/role in user information popover. Add user role-- "Administrator", "Member", "Bot" or "Guest" under 'Local time' in user information popover. Fixes part of #10754 --- frontend_tests/node_tests/popovers.js | 1 + static/js/popovers.js | 1 + static/templates/user_info_popover_content.handlebars | 2 ++ 3 files changed, 4 insertions(+) diff --git a/frontend_tests/node_tests/popovers.js b/frontend_tests/node_tests/popovers.js index 3749259758..931cefb479 100644 --- a/frontend_tests/node_tests/popovers.js +++ b/frontend_tests/node_tests/popovers.js @@ -145,6 +145,7 @@ run_test('sender_hover', () => { user_email: 'alice@example.com', user_id: 42, user_time: undefined, + user_type: i18n.t('Member'), presence_status: 'offline', user_last_seen_time_status: 'translated: More than 2 weeks ago', pm_with_uri: '#narrow/pm-with/42-alice', diff --git a/static/js/popovers.js b/static/js/popovers.js index cb073275ae..6086c2f4cc 100644 --- a/static/js/popovers.js +++ b/static/js/popovers.js @@ -129,6 +129,7 @@ function render_user_info_popover(user, popover_element, is_sender_popover, priv user_id: user.user_id, user_last_seen_time_status: user_last_seen_time_status(user.user_id), user_time: people.get_user_time(user.user_id), + user_type: people.get_user_type(user.user_id), }; popover_element.popover({ diff --git a/static/templates/user_info_popover_content.handlebars b/static/templates/user_info_popover_content.handlebars index 834e303f2e..84251c0866 100644 --- a/static/templates/user_info_popover_content.handlebars +++ b/static/templates/user_info_popover_content.handlebars @@ -27,6 +27,8 @@ {{#if user_time}}
  • {{ user_time }} {{#tr this}}Local time{{/tr}}
    • {{/if}} + +
  • {{ user_type }}
    • {{#if show_user_profile}}