paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 11:33:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools: Refactor ScreenshotConfig for non-webhook integrations.

Browse Source
This commit is contained in:
PIG208
2021-03-29 21:02:37 +08:00
committed by Tim Abbott
parent 9ac55a8cf6
commit 562cbcac1c
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
zerver/lib/integrations.py
View File

@@ -233,11 +233,15 @@ def split_fixture_path(path: str) -> Tuple[str, str]:
@dataclass
class ScreenshotConfig:
class BaseScreenshotConfig:
fixture_name: str
image_name: str = "001.png"
image_dir: Optional[str] = None
bot_name: Optional[str] = None
@dataclass
class ScreenshotConfig(BaseScreenshotConfig):
payload_as_query_param: bool = False
payload_param_name: str = "payload"
extra_params: Dict[str, str] = field(default_factory=dict)
@@ -246,9 +250,12 @@ class ScreenshotConfig:
def get_fixture_and_image_paths(
integration: WebhookIntegration, screenshot_config: ScreenshotConfig
integration: Integration, screenshot_config: BaseScreenshotConfig
) -> Tuple[str, str]:
fixture_dir = os.path.join("zerver", "webhooks", integration.name, "fixtures")
if isinstance(integration, WebhookIntegration):
fixture_dir = os.path.join("zerver", "webhooks", integration.name, "fixtures")
else:
fixture_dir = os.path.join("zerver", "integration_fixtures", integration.name)
fixture_path = os.path.join(fixture_dir, screenshot_config.fixture_name)
image_dir = screenshot_config.image_dir or integration.name
image_name = screenshot_config.image_name
@@ -658,7 +665,7 @@ NO_SCREENSHOT_WEBHOOKS = {
}
DOC_SCREENSHOT_CONFIG: Dict[str, List[ScreenshotConfig]] = {
DOC_SCREENSHOT_CONFIG: Dict[str, List[BaseScreenshotConfig]] = {
"airbrake": [ScreenshotConfig("error_message.json")],
"alertmanager": [
ScreenshotConfig("alert.json", extra_params={"name": "topic", "desc": "description"})