paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Inline message_list.prepend.

Browse Source
This commit is contained in:
Steve Howell
2018-05-13 20:46:25 +00:00
committed by Tim Abbott
parent 6834745feb
commit 56f872507c
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/node_tests/message_list.js
View File

@@ -32,7 +32,7 @@ function accept_all_filter() {
run_test('basics', () => { run_test('basics', () => {
var table; var table;
var filter = {}; var filter = accept_all_filter();
var list = new MessageList(table, filter); var list = new MessageList(table, filter);
@@ -101,7 +101,7 @@ run_test('basics', () => {
id: 40, id: 40,
}, },
]; ];
list.prepend(old_messages, true); list.add_messages(old_messages);
assert.equal(list.first().id, 30); assert.equal(list.first().id, 30);
assert.equal(list.last().id, 80); assert.equal(list.last().id, 80);

8
static/js/message_list.js
View File

@@ -39,7 +39,8 @@ exports.MessageList.prototype = {
return true; return true;
} }
if (top_messages.length > 0) { if (top_messages.length > 0) {
self.prepend(top_messages); top_messages = this.data.prepend(top_messages);
self.view.prepend(top_messages);
} }
if (bottom_messages.length > 0) { if (bottom_messages.length > 0) {
@@ -261,11 +262,6 @@ exports.MessageList.prototype = {
} }
}, },
prepend: function MessageList_prepend(messages) {
var viewable_messages = this.data.prepend(messages);
this.view.prepend(viewable_messages);
},
remove_and_rerender: function MessageList_remove_and_rerender(messages) { remove_and_rerender: function MessageList_remove_and_rerender(messages) {
this.data.remove(messages); this.data.remove(messages);
this.rerender(); this.rerender();