paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Remove unused user_groups_in_realm function.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-08-13 18:27:50 -07:00
committed by Tim Abbott
parent fdbde9f9c2
commit 57acac12fa
2 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/lib/user_groups.py
View File

@@ -22,11 +22,6 @@ def access_user_group_by_id(user_group_id: int, user_profile: UserProfile) -> Us
return user_group return user_group
def user_groups_in_realm(realm: Realm) -> List[UserGroup]:
user_groups = UserGroup.objects.filter(realm=realm)
return list(user_groups)
def user_groups_in_realm_serialized(realm: Realm) -> List[Dict[str, Any]]: def user_groups_in_realm_serialized(realm: Realm) -> List[Dict[str, Any]]:
"""This function is used in do_events_register code path so this code """This function is used in do_events_register code path so this code
should be performant. We need to do 2 database queries because should be performant. We need to do 2 database queries because

10
zerver/tests/test_user_groups.py
View File

@@ -14,7 +14,6 @@ from zerver.lib.user_groups import (
create_user_group, create_user_group,
get_memberships_of_users, get_memberships_of_users,
get_user_groups, get_user_groups,
user_groups_in_realm,
user_groups_in_realm_serialized, user_groups_in_realm_serialized,
) )
from zerver.models import Realm, UserGroup, UserGroupMembership, UserProfile, get_realm from zerver.models import Realm, UserGroup, UserGroupMembership, UserProfile, get_realm
@@ -27,15 +26,6 @@ class UserGroupTestCase(ZulipTestCase):
members = [self.example_user("othello")] members = [self.example_user("othello")]
return create_user_group(group_name, members, realm) return create_user_group(group_name, members, realm)
def test_user_groups_in_realm(self) -> None:
realm = get_realm("zulip")
self.assert_length(user_groups_in_realm(realm), 1)
self.create_user_group_for_test("support")
user_groups = user_groups_in_realm(realm)
self.assert_length(user_groups, 2)
names = {ug.name for ug in user_groups}
self.assertEqual(names, {"hamletcharacters", "support"})
def test_user_groups_in_realm_serialized(self) -> None: def test_user_groups_in_realm_serialized(self) -> None:
realm = get_realm("zulip") realm = get_realm("zulip")
user_group = UserGroup.objects.first() user_group = UserGroup.objects.first()